Fix SAFETY
comment tag casing in undocumented_unsafe_blocks
#8138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the lint introduced in #7748 to suggest adding a
SAFETY
comment instead of aSafety
comment.Searching for
// Safety:
in rust-lang/rust yields 67 results while// SAFETY:
yields 1072.I think it's safe to say that this comment tag is written in upper case, just like
TODO
,FIXME
and so on are. As such I would expect this lint to follow the official convention as well.Note that I intentionally introduced some casing diversity in
tests/ui/undocumented_unsafe_blocks.rs
to test more cases than justSafety:
.changelog: Capitalize
SAFETY
comment in [undocumented_unsafe_blocks
]