Fix syntax checking on 'cdylib' libraries. #186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
added a commit
to ehuss/sublime-rust
that referenced
this pull request
May 31, 2017
Adapted from rust-lang#186, thanks @smbolton.
jasonwilliams
pushed a commit
that referenced
this pull request
Jul 8, 2017
* New Cargo build system.
* Fix wrapping of commands in GitHub flavored markdown.
* Minor fixes to unittests for Rust 1.16.
* Add support for "cargo check".
* Support clippy for on-save checking.
* Fix on-save syntax check running clippy multiple times.
* Add ability to configure cargo build features.
* Support setting environment variables.
This includes a dependency on shellenv to capture the user's environment from their login shell.
* Normalize paths when dealing with settings.
This fixes some problems running tests on Windows.
* Disable on-load message display for tests.
This was causing random breakage (particularly on Windows).
* Fix race condition in tests manifested on linux.
* Add support for custom build variants.
This includes some significant changes to how the current
package is selected. It should work a little better if you
have multiple packages.
* Add support for a default path/package.
* Add "Automatic" build variant.
* Stop looking for JSON output during Cargo build once compile is finished.
This fixes issues with "cargo run" if your program outputs { at the start of a line.
* Better fix for checking when we should stop looking for JSON output.
The previous fix caused issues with Clippy.
* Remove debug print left behind.
* Minor updates for rust 1.17.
* Change message tests to check the region of the message.
* Fix error highlighting for nested macros.
* Fix clearing of error regions.
* Add rust_phantom_style and rust_region_style config settings.
Fixes #182.
* Honor show_errors_inline config setting for Cargo build.
* Fix links in messages that are surrounded by angled brackets.
* Consolidate all Cargo config commands into a single command.
Add commands to configure extra arguments and environment variables.
* Document the new build configure command.
Also document the `default_path` option.
* On-save syntax checking now uses configuration settings from the build
system.
* Finish documenting all settings, and include link to new build docs.
* Fix Cargo environment variable config command when selecting "all build
commands".
* Only print warning about sublime-project when saving setings.
* Fix target detection for cdylib.
Adapted from #186, thanks @smbolton.
* Update tests for new messages in rust 1.18.
|
hi @smbolton there's a conflict now we've merged in the other branch, could you fix that up? |
|
I updated my branch to support cdylib, so it should be working now. (#165 contained the fix already) |
urschrei
pushed a commit
to urschrei/sublime-rust
that referenced
this pull request
Jan 30, 2018
* New Cargo build system.
* Fix wrapping of commands in GitHub flavored markdown.
* Minor fixes to unittests for Rust 1.16.
* Add support for "cargo check".
* Support clippy for on-save checking.
* Fix on-save syntax check running clippy multiple times.
* Add ability to configure cargo build features.
* Support setting environment variables.
This includes a dependency on shellenv to capture the user's environment from their login shell.
* Normalize paths when dealing with settings.
This fixes some problems running tests on Windows.
* Disable on-load message display for tests.
This was causing random breakage (particularly on Windows).
* Fix race condition in tests manifested on linux.
* Add support for custom build variants.
This includes some significant changes to how the current
package is selected. It should work a little better if you
have multiple packages.
* Add support for a default path/package.
* Add "Automatic" build variant.
* Stop looking for JSON output during Cargo build once compile is finished.
This fixes issues with "cargo run" if your program outputs { at the start of a line.
* Better fix for checking when we should stop looking for JSON output.
The previous fix caused issues with Clippy.
* Remove debug print left behind.
* Minor updates for rust 1.17.
* Change message tests to check the region of the message.
* Fix error highlighting for nested macros.
* Fix clearing of error regions.
* Add rust_phantom_style and rust_region_style config settings.
Fixes rust-lang#182.
* Honor show_errors_inline config setting for Cargo build.
* Fix links in messages that are surrounded by angled brackets.
* Consolidate all Cargo config commands into a single command.
Add commands to configure extra arguments and environment variables.
* Document the new build configure command.
Also document the `default_path` option.
* On-save syntax checking now uses configuration settings from the build
system.
* Finish documenting all settings, and include link to new build docs.
* Fix Cargo environment variable config command when selecting "all build
commands".
* Only print warning about sublime-project when saving setings.
* Fix target detection for cdylib.
Adapted from rust-lang#186, thanks @smbolton.
* Update tests for new messages in rust 1.18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little change, to support the 'cdylib' library type. Thanks!