Skip to content

Remove float, int, and uint as built-in types. #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2017

Conversation

shepmaster
Copy link
Member

These went away pre Rust-1.0 and are valid identifiers. Went ahead and
removed them from the tests as well, replacing them with real types of
the same number of characters.

These went away pre Rust-1.0 and are valid identifiers. Went ahead and
removed them from the tests as well, replacing them with real types of
the same number of characters.
@shepmaster
Copy link
Member Author

shepmaster commented Sep 14, 2017

For reference, I was looking at some code like

pub use num::bigint::BigUint;

impl From<BigUint> for Literal {
    fn from(uint: BigUint) -> Self { Literal::Integer(uint) }
}

And was confused that the argument name and type were highlighted the same :-)

@tromey
Copy link
Contributor

tromey commented Sep 14, 2017

Thank you for the patch.

@tromey tromey merged commit 9eda807 into rust-lang:master Sep 14, 2017
@shepmaster shepmaster deleted the no-more-int-float branch September 14, 2017 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants