Skip to content

Rename LIBDIR_RELATIVE to CFG_LIBDIR_RELATIVE #11420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jan 9, 2014 · 1 comment · Fixed by #11521
Closed

Rename LIBDIR_RELATIVE to CFG_LIBDIR_RELATIVE #11420

brson opened this issue Jan 9, 2014 · 1 comment · Fixed by #11521
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jan 9, 2014

This looks bad:

configure: CFG_SRC_DIR          := /home/brian/rust-0.9/
configure: CFG_BUILD_DIR        := /home/brian/rust-0.9/
configure: CFG_OSTYPE           := unknown-linux-gnu
configure: CFG_CPUTYPE          := x86_64
configure: CFG_CONFIGURE_ARGS   := --prefix=/home/brian/rust-0.9-insta ...
configure: CFG_PREFIX           := /home/brian/rust-0.9-install
configure: CFG_BUILD            := x86_64-unknown-linux-gnu
configure: CFG_HOST             := x86_64-unknown-linux-gnu
configure: CFG_TARGET           := x86_64-unknown-linux-gnu
configure: CFG_C_COMPILER       := gcc
configure: CFG_LIBDIR           := /home/brian/rust-0.9-install/lib
configure: CFG_RUSTLIBDIR       := rustlib
configure: LIBDIR_RELATIVE      := lib
configure: CFG_DISABLE_MANAGE_SUBMODULES := 1
configure: CFG_ANDROID_CROSS_PATH := /opt/ndk_standalone
configure: CFG_MINGW32_CROSS_PATH :=
configure: CFG_MANDIR           := /home/brian/rust-0.9-install/share/ ...
configure: CFG_LLVM_ROOT        :=
configure: CFG_LLVM_SRC_DIR     := /home/brian/rust-0.9/src/llvm/
configure: CFG_LLVM_BUILD_DIR_x86_64_unknown_linux_gnu := /home/brian/rust-0.9/x86_64-unknown ...
configure: CFG_LLVM_INST_DIR_x86_64_unknown_linux_gnu := /home/brian/rust-0.9/x86_64-unknown ...
@jhasse
Copy link
Contributor

jhasse commented Jan 10, 2014

I've named it LIBDIR_RELATIVE because it isn't configurable (you can't change it using ./configure --libdir-relative=foo). Maybe it shouldn't be printed at all? After all CFG_LIBDIR already tells enough.

@dguenther dguenther mentioned this issue Jan 14, 2014
Merged
@bors bors closed this as completed in dd8b011 Jan 15, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 25, 2023
@bors
Auto merge of rust-lang#11518 - mojave2:issue-11420, r=Alexendoo
4d143d7 
fix FP with needless_raw_string_hashes

changelog: Fix [`needless_raw_string_hashes`]: Continue the lint checking of raw string when `needless_raw_strings` is allowed.

fix rust-lang#11420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed LIBDIR_RELATIVE to CFG_LIBDIR_RELATIVE
2 participants
@jhasse @brson