Skip to content

lstat implementation on windows #12795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lbonn opened this issue Mar 9, 2014 · 2 comments
Closed

lstat implementation on windows #12795

lbonn opened this issue Mar 9, 2014 · 2 comments
Labels
O-windows Operating system: Windows

Comments

@lbonn
Copy link
Contributor

lbonn commented Mar 9, 2014

Link and symlink capabilities exist on win32 platform, yet lstat's implementation is still missing.

Some fs operations need it to work properly, for example rmdir_recursive (#12573)
lbonn added a commit to lbonn/rust that referenced this issue Mar 10, 2014
@lbonn
fs: use an iterative algorithm for 'rmdir_recursive'
2d754b4 
For now, the windows version uses stat, just as before.
We should switch back to lstat as soon as rust-lang#12795 is closed.
lbonn added a commit to lbonn/rust that referenced this issue Mar 10, 2014
@lbonn
fs: units tests for mkdir_recusive and rmdir_recursive
164b7c2 
The rmdir test is blocked by rust-lang#12795 on windows.
@lbonn
Copy link
Contributor Author

lbonn commented Mar 11, 2014

After a little search, I noticed that rust is an outlier by trying to support links on windows: python and golang don't provide link functions and alias lstat to stat.

However, libuv looks interesting in this regard:
https://github.com/joyent/libuv/blob/1dc2709b999a84520ab1b3c56c0e082bf8617c1f/src/win/fs.c#L971

@brson brson mentioned this issue Aug 12, 2014
Closed
33 tasks
@steveklabnik
Copy link
Member 

src/libstd/sys/unix/fs2.rs:pub fn lstat(p: &Path) -> io::Result<FileAttr> {

Seems to exist now. 🎊

@eefriedman eefriedman mentioned this issue Oct 27, 2015
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12795 - jonas-schievink:proc-macro-abi-1.64, …
ee2d5fe 
…r=jonas-schievink

feat: Support the 1.64 nightly proc macro ABI

Should resolve rust-lang/rust-analyzer#12600

Not sure why I thought the Rust version was the same as on beta, that's never the case (but future nightly changes can break the ABI again).
bors added a commit to rust-lang-ci/rust that referenced this issue May 30, 2024
@bors
Auto merge of rust-lang#12809 - GuillaumeGomez:missing-backticks-fix,…
5d10538 
… r=y21

Correctly handle closing parens in `missing_backticks` doc lint

Fixes rust-lang#12795.

changelog: Correctly handle closing parens in `doc_markdown` lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @brson @lbonn