Skip to content

Turn on --disable-debug for distribution? #20713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jan 7, 2015 · 6 comments
Closed

Turn on --disable-debug for distribution? #20713

brson opened this issue Jan 7, 2015 · 6 comments
Labels
P-medium Medium priority
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Jan 7, 2015

Currently we do not set this flag on nightly/beta/stable, but with overflow checking it will have a more pronounced, though yet unmeasured, performance impact. Seems like we will likely want to turn off overflow checks in std for distributed binaries.
@brson
Copy link
Contributor Author

brson commented Jan 7, 2015

Nominating because this could have a big impact on perception.

@pnkfelix
Copy link
Member

pnkfelix commented Jan 7, 2015

(deleting earlier comment that was confused by a typo in the title)

@brson brson changed the title Turn off --disable-debug for distribution? Turn on --disable-debug for distribution? Jan 7, 2015
@brson
Copy link
Contributor Author

brson commented Jan 7, 2015

@pnkfelix Oops. 'off' -> 'on'

brson added a commit to brson/rust that referenced this issue Jan 7, 2015
@brson
mk: Disable extra debugging on the non-dev release channels. rust-lan…
f255866 
…g#20713

This makes std not do overflow checks for releases.
@brson
Copy link
Contributor Author

brson commented Jan 7, 2015

#20715

@brson brson removed the I-nominated label Jan 15, 2015
@brson brson added this to the 1.0 milestone Jan 15, 2015
@brson brson added the P-medium Medium priority label Jan 15, 2015
@nikomatsakis
Copy link
Contributor

cc rust-lang/rfcs#563

@pnkfelix
Copy link
Member

pnkfelix commented Apr 2, 2015

@alexcrichton says this is effectively done now.

@pnkfelix pnkfelix closed this as completed Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-medium Medium priority
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@brson @nikomatsakis @pnkfelix