-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Convert the runtime to a crate #2377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This would end up meaning that you can't use rust without linking to another rust crate. That's a pretty large negative, sadly. |
Why is it a negative? Seems ok to me. |
I don't remember. I think because it makes porting harder since there are no standalone test cases. |
After attempting to convert the runtime to a crate independent of core I now think it is appropriate (significantly easier) to just merge rt and core. The primary reason is that the runtime crate will have to export the entire runtime interface as Rust functions, and that will depend on Rust libc definitions. As more Rust runtime code is written, more of core will need to migrate to rt. This will introduce the new limitation that it is not possible to compile rust code without linking to core. |
This will also mean that no crate except for core can use native runtime functions directly (they will be internal to core). We currently have a number of test cases that use the runtime for testing native functions. |
We're not doing this. Instead merging rt/core. |
Add test flag for running a test only on the host
Fix minor typo in installation.md
Fix minor typo in installation.md
Converting the runtime to a Rust crate appears to be an interesting and useful thing to do.
Benefits:
Cons:
Guide to success:
The text was updated successfully, but these errors were encountered: