Skip to content

repeated-assert-0.1.2 beta regression #43676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
est31 opened this issue Aug 5, 2017 · 3 comments
Closed

repeated-assert-0.1.2 beta regression #43676

est31 opened this issue Aug 5, 2017 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 5, 2017

repeated-assert version 0.1.2 regressed from stable to beta (full log):

Aug 03 17:17:58.424 INFO blam! ---- tests::multiple_failure_2 stdout ----
Aug 03 17:17:58.424 INFO blam! 	thread 'tests::multiple_failure_2' panicked at 'assertion failed: `(left == right)`
Aug 03 17:17:58.424 INFO blam!   left: `11`,
Aug 03 17:17:58.424 INFO blam!  right: `12`: a != b', src/lib.rs:225:8
Aug 03 17:17:58.424 INFO blam! note: Panic did not include expected string 'assertion failed: `(left == right)` (left: `11`, right: `12`): a != b'

cc @dfaust
@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017 •
edited
Loading

#42541: the format of assert_eq messages changed. I don't think this is something we are going to guarantee stability on, or revert.

dfaust added a commit to dfaust/repeated-assert that referenced this issue Aug 5, 2017
@dfaust
Fix tests on rustc 1.20
c7e7978 
rust-lang/rust#43676
@arielb1 arielb1 added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 5, 2017
@dfaust
Copy link

dfaust commented Aug 5, 2017

I fixed the test and published a new release to crates.io.

@est31
Copy link
Member Author

est31 commented Aug 5, 2017

@dfaust thanks!

@est31 est31 closed this as completed Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dfaust @arielb1 @est31