Reduce a large amount of uv boilerplate #10256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an raii wrapper means that there's no need for a '_self' variant and we can greatly reduce the amount of 'self_'-named variables.
|
Does this remove some of the non-once |
|
Sadly no removal of |
|
@bors: retry |
|
I'm going to land this elsewhere. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 10, 2023
Fix version declared for semicolon_inside_block and semicolon_outside… As per Issue rust-lang#10244, the lint were documentated as being part of 1.66.0 but will actually be released 1.68.0 . changelog: [`semicolon_inside_block`]: Documentation fix Fixes rust-lang#10244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a large number of the wrapper functions from libuv. Most of these only existed for weird linker purposes, but now that we're statically linking libuv to librustuv, we can use them all directly (as they were intended to be!
This also refactors a bit of uv handle initialization/management, purely to reduce the amount of code that's needed to look at.
Finally, this removes the
home_for_ioclosure-based function, replacing it with an RAII-oriented function (fire_missiles!)