Skip to content

Robustly read remaining bytes in a character #11375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/libstd/io/buffered.rs
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ mod test {
use io;
use prelude::*;
use super::*;
use super::super::mem::{MemReader, MemWriter};
use super::super::mem::{MemReader, MemWriter, BufReader};
use Harness = extra::test::BenchHarness;

/// A type, free to create, primarily intended for benchmarking creation of wrappers that, just
Expand Down Expand Up @@ -526,6 +526,12 @@ mod test {
assert_eq!(reader.read(buf), None);
}

#[test]
fn read_char_buffered() {
let buf = [195u8, 159u8];
let mut reader = BufferedReader::with_capacity(1, BufReader::new(buf));
assert_eq!(reader.read_char(), Some('ß'));
}

#[bench]
fn bench_buffered_reader(bh: &mut Harness) {
Expand Down
12 changes: 9 additions & 3 deletions src/libstd/io/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1212,9 +1212,15 @@ pub trait Buffer: Reader {
};
if width == 0 { return None } // not uf8
let mut buf = [0, ..4];
match self.read(buf.mut_slice_to(width)) {
Some(n) if n == width => {}
Some(..) | None => return None // read error
{
let mut start = 0;
loop {
match self.read(buf.mut_slice(start, width)) {
Some(n) if n == width - start => break,
Some(n) if n < width - start => { start += n; }
Some(..) | None => return None // read error
}
}
}
match str::from_utf8_opt(buf.slice_to(width)) {
Some(s) => Some(s.char_at(0)),
Expand Down