Reduce warnings #11918
Merged
Reduce warnings #11918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use super::*; | ||
| // use io::net::ip::Ipv4Addr; | ||
| // use prelude::*; | ||
| // use super::*; |
There was a problem hiding this comment.
Instead of commenting these out, could you delete them?
|
One minor comment, otherwise looks good to me! |
Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
|
Fixed. r? @alexcrichton |
bors
added a commit
that referenced
this pull request
Jan 31, 2014
Moving forward to green waterfall.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 16, 2023
docs(explicit_write): add missing backtick to complete code snippet close rust-lang#11918 *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: [`explicit_write`]: add missing backtick to document to complete code snippet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving forward to green waterfall.