A couple cleanup patches to the new Hash framework #12522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This all looks fine to me, although I thought it was nice keeping |
|
I also had second thoughts about having Hash in prelude. I would be fine leaving it out. |
|
r=me if it stays out of the prelude, if it remains I'm curious what other opinions are |
bors
added a commit
that referenced
this pull request
Feb 25, 2014
This patch series does a couple things: * replaces manual `Hash` implementations with `#[deriving(Hash)]` * adds `Hash` back to `std::prelude` * minor cleanup of whitespace and variable names.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 4, 2024
…dnet Correct version for incompatible_msrv Unsure what happened here Probably what caused rust-lang/blog.rust-lang.org#1277 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series does a couple things:
Hashimplementations with#[deriving(Hash)]Hashback tostd::prelude