Skip to content

rustdoc: use ThinVec for generic arg parts #136265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

notriddle
Copy link
Contributor

This reduces the size of both these args, and of path segments, so should measurably help with memory use.

This reduces the size of both these args, and of path segments,
so should measurably help with memory use.
@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 29, 2025
@compiler-errors
Copy link
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
rustdoc: use ThinVec for generic arg parts

This reduces the size of both these args, and of path segments, so should measurably help with memory use.
@bors
Copy link
Collaborator

bors commented Jan 29, 2025

⌛ Trying commit 3814ec5 with merge 39e809d...

@bors
Copy link
Collaborator

bors commented Jan 30, 2025

☀️ Try build successful - checks-actions
Build commit: 39e809d (39e809d66cdc2761c224c082c361c06112189a8c)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (39e809d): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.3% [-0.5%, -0.1%] 20
Improvements ✅
(secondary)
-0.4% [-0.6%, -0.2%] 17
All ❌✅ (primary) -0.3% [-0.5%, -0.1%] 20

Max RSS (memory usage)

Results (primary -2.8%, secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.0% [2.2%, 3.8%] 2
Improvements ✅
(primary)
-2.8% [-3.6%, -2.0%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.8% [-3.6%, -2.0%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.289s -> 776.243s (-0.13%)
Artifact size: 328.44 MiB -> 328.47 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 30, 2025
@fmease
Copy link
Member

fmease commented Jan 30, 2025

Lovely, thanks!

r? fmease @bors r+

@bors
Copy link
Collaborator

bors commented Jan 30, 2025

📌 Commit 3814ec5 has been approved by fmease

It is now in the queue for this repository.

@rustbot rustbot assigned fmease and unassigned GuillaumeGomez Jan 30, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 5, 2025
rustdoc: use ThinVec for generic arg parts

This reduces the size of both these args, and of path segments, so should measurably help with memory use.
@bors
Copy link
Collaborator

bors commented Feb 5, 2025

⌛ Testing commit 3814ec5 with merge a3fd735...

@bors
Copy link
Collaborator

bors commented Feb 5, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2025
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@fmease
Copy link
Member

fmease commented Feb 5, 2025

spurious @bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2025
@bors
Copy link
Collaborator

bors commented Feb 6, 2025

⌛ Testing commit 3814ec5 with merge 3086510...

@bors
Copy link
Collaborator

bors commented Feb 6, 2025

☀️ Test successful - checks-actions
Approved by: fmease
Pushing 3086510 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 6, 2025
@bors bors merged commit 3086510 into rust-lang:master Feb 6, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 6, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3086510): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.3% [-0.5%, -0.2%] 20
Improvements ✅
(secondary)
-0.4% [-0.6%, -0.1%] 18
All ❌✅ (primary) -0.3% [-0.5%, -0.2%] 20

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.594s -> 778.16s (0.07%)
Artifact size: 329.01 MiB -> 329.00 MiB (-0.00%)

@notriddle notriddle deleted the notriddle/clean-up branch February 6, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants