Skip to content

Do not ICE when reassigning in GatherLocalsVisitor on the bad path #140827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not ICE when reassigning in GatherLocalsVisitor on the bad path #140827

wants to merge 1 commit into from
+39 −2

Conversation

compiler-errors
Copy link
Member

Fixes #140785
Fixes #140730

See comment in code.

r? oli-obk

@compiler-errors compiler-errors marked this pull request as ready for review May 8, 2025 19:44
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented May 9, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 9, 2025

📌 Commit d288e3c has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 9, 2025
@GuillaumeGomez
Rollup merge of rust-lang#140827 - compiler-errors:gather-locals-twic…
b96950b 
…e, r=oli-obk

Do not ICE when reassigning in GatherLocalsVisitor on the bad path

Fixes rust-lang#140785
Fixes rust-lang#140730

See comment in code.

r? oli-obk
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 9, 2025
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 9, 2025
@GuillaumeGomez
Rollup merge of rust-lang#140827 - compiler-errors:gather-locals-twic…
7e94566 
…e, r=oli-obk

Do not ICE when reassigning in GatherLocalsVisitor on the bad path

Fixes rust-lang#140785
Fixes rust-lang#140730

See comment in code.

r? oli-obk
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 9, 2025
Closed
@compiler-errors
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: gather_locals ICE:gather_locals
5 participants
@compiler-errors @rust-log-analyzer @oli-obk @bors @rustbot