Rollup of 5 pull requests #140838

Zalathar · 2025-05-09T06:25:06Z

Successful merges:

Use span before macro expansion in lint for-loops-over-falibles #140801 (Use span before macro expansion in lint for-loops-over-falibles)
add signed ints to unn- transmutes to ensure feature parity #140804 (add signed ints to unn- transmutes to ensure feature parity)
Fix tests/rustdoc-json triagebot message path #140812 (Fix tests/rustdoc-json triagebot message path)
bootstrap: more consistent use of ... when citing configuration snippets #140817 (bootstrap: more consistent use of ... when citing configuration snippets)
Enable non-leaf Frame Pointers for Arm64 Windows #140828 (Enable non-leaf Frame Pointers for Arm64 Windows)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

…h clippy

…ppets

Use span before macro expansion in lint for-loops-over-falibles Fixes rust-lang#140747 I think there are going to be a lot of cases where macros are expanded in the compiler resulting in span offsets, and I'd like to know how that's typically handled. Does it have to be handled specially every time?

add signed ints to unn- transmutes to ensure feature parity i forgot a few cases rust-lang/rust-clippy#14703 adds - char -> i32 - i32 -> char - float -> size () - size -> float - i32 -> float ``@rustbot`` label L-unnecessary_transmutes

Fix `tests/rustdoc-json` triagebot message path r? ```@aDotInTheVoid```

bootstrap: more consistent use of `...` when citing configuration snippets

Enable non-leaf Frame Pointers for Arm64 Windows Microsoft recommends enabling frame pointers for Arm64 Windows as it enables fast stack walking, from <https://learn.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-170#integer-registers>: > The frame pointer (x29) is required for compatibility with fast stack walking used by ETW and other services. It must point to the previous {x29, x30} pair on the stack. I'm setting this to "non-leaf" as leaf functions shouldn't be spilling registers and so won't touch the frame pointer.

Zalathar · 2025-05-09T06:25:49Z

@bors try

Zalathar · 2025-05-09T06:26:37Z

Checking whether #140836 (comment) is reproducible.

Rollup of 5 pull requests Successful merges: - rust-lang#140801 (Use span before macro expansion in lint for-loops-over-falibles) - rust-lang#140804 (add signed ints to unn- transmutes to ensure feature parity) - rust-lang#140812 (Fix `tests/rustdoc-json` triagebot message path) - rust-lang#140817 (bootstrap: more consistent use of `...` when citing configuration snippets) - rust-lang#140828 (Enable non-leaf Frame Pointers for Arm64 Windows) r? `@ghost` `@rustbot` modify labels: rollup --- try-job: test-various

bors · 2025-05-09T06:27:01Z

⌛ Trying commit d91e86e with merge 063ae3a...

bors · 2025-05-09T07:48:52Z

☀️ Try build successful - checks-actions
Build commit: 063ae3a (063ae3ada0e4bddc4e2af5ccb6e79f72b3a28776)

Zalathar · 2025-05-09T07:49:29Z

@bors r+ rollup=never p=5

bors · 2025-05-09T07:49:31Z

📌 Commit d91e86e has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-05-09T08:31:22Z

⌛ Testing commit d91e86e with merge da1e442...

bors · 2025-05-09T11:44:46Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing da1e442 to master...

rust-timer · 2025-05-09T11:46:12Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#140801	Use span before macro expansion in lint for-loops-over-fali…	`2aa01e2f9ef5f0509990f1680c9c773fcf50ffff` (link)
#140804	add signed ints to unn- transmutes to ensure feature parity	`79be468f6083621bfb516f585221ce4b0b8daa3b` (link)
#140812	Fix `tests/rustdoc-json` triagebot message path	`e2616f7fec7ddf97a61a0ef8316783ce42f041fb` (link)
#140817	bootstrap: more consistent use of `...` when citing configu…	`ec82a8c5d4a3e222b001fbea540505184905c46c` (link)
#140828	Enable non-leaf Frame Pointers for Arm64 Windows	`ea4e3a39528531884adfb1d674688e12ab8ab1f1` (link)

previous master: a7b1b24587

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-05-09T11:47:37Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a7b1b24 (parent) -> da1e442 (this PR)

Test differences

Show 2 test diffs

Stage 1

[ui] tests/ui/lint/for-loops-over-falibles/macro-issue-140747.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/lint/for-loops-over-falibles/macro-issue-140747.rs: [missing] -> pass (J1)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard da1e442ebde8d527f3872c0cac5b371ff6ea0cc7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 6205.5s -> 9408.9s (51.6%)
aarch64-apple: 3907.9s -> 4624.1s (18.3%)
dist-x86_64-apple: 7714.9s -> 8564.8s (11.0%)
dist-aarch64-apple: 5319.2s -> 5881.0s (10.6%)
dist-arm-linux: 5004.9s -> 4531.8s (-9.5%)
dist-armv7-linux: 5318.8s -> 5639.5s (6.0%)
x86_64-apple-2: 5902.6s -> 6204.5s (5.1%)
x86_64-gnu-tools: 5857.4s -> 6155.7s (5.1%)
dist-x86_64-netbsd: 4948.5s -> 5179.0s (4.7%)
dist-x86_64-mingw: 7920.4s -> 7565.6s (-4.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-05-09T13:16:52Z

Finished benchmarking commit (da1e442): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.4%, 2.7%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-1.2%, -0.4%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-1.2%, 2.7%]	11

Cycles

Results (primary -0.6%, secondary -3.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-1.0%, -0.4%]	13
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-0.6%	[-1.0%, -0.4%]	13

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.392s -> 771.723s (-0.09%)
Artifact size: 365.74 MiB -> 365.67 MiB (-0.02%)

xizheyin and others added 11 commits May 8, 2025 21:17

Add ui test for for-loops-over-falibles

c0f0b51

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

Use span before macro expansion in lint for-loops-over-falibles

88c1796

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

Fix tests/rustdoc-json path

eff20bf

add signed integers to unnecessary_lints to ensure feature parity wit…

3b4c493

…h clippy

bootstrap: more consistent use of ... when citing configuration sni…

0326a2c

…ppets

Enable non-leaf Frame Pointers for Arm64 Windows

d951c41

Rollup merge of rust-lang#140812 - jieyouxu:typo-fix, r=aDotInTheVoid

c922eb9

Fix `tests/rustdoc-json` triagebot message path r? ```@aDotInTheVoid```

Rollup merge of rust-lang#140817 - RalfJung:bootstrap-msg, r=jieyouxu

e3873f5

bootstrap: more consistent use of `...` when citing configuration snippets

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2025

bors merged commit da1e442 into rust-lang:master May 9, 2025
1 check passed

rustbot added this to the 1.88.0 milestone May 9, 2025

Zalathar deleted the rollup-13hybry branch May 9, 2025 12:01

This was referenced May 9, 2025

[beta] [also fit for beta rollup] [HOTFIX] Don't delay a bug on malformed meta items involving interpolated tokens #140601

Closed

[beta] Clippy beta backport #140810

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #140838

Rollup of 5 pull requests #140838

Zalathar commented May 9, 2025 •

edited

Loading

Zalathar commented May 9, 2025

Zalathar commented May 9, 2025

bors commented May 9, 2025

bors commented May 9, 2025

Zalathar commented May 9, 2025

bors commented May 9, 2025

bors commented May 9, 2025

bors commented May 9, 2025

rust-timer commented May 9, 2025

github-actions bot commented May 9, 2025

Stage 1

Stage 2

rust-timer commented May 9, 2025

Rollup of 5 pull requests #140838

Rollup of 5 pull requests #140838

Conversation

Zalathar commented May 9, 2025 • edited Loading

Zalathar commented May 9, 2025

Zalathar commented May 9, 2025

bors commented May 9, 2025

bors commented May 9, 2025

Zalathar commented May 9, 2025

bors commented May 9, 2025

bors commented May 9, 2025

bors commented May 9, 2025

rust-timer commented May 9, 2025

github-actions bot commented May 9, 2025

Test differences

Stage 1

Stage 2

Job duration changes

rust-timer commented May 9, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Zalathar commented May 9, 2025 •

edited

Loading