enable jemalloc debugging in unoptimized builds #17083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The performance hit from these checks is significant, but unoptimized builds are already incredibly slow. Enabling these checks results in better test coverage since there are bots doing unoptimized builds, and the cost is relatively small in the context of an unoptimized build. This also allows using `JEMALLOC_FLAGS` to override the default configure flags.
|
I suspect that if this turns out to slow down the bots unbearably, we can always revert it. Otherwise, the more debugging the merrier! |
|
@alexcrichton: I think it just slows down allocation by 20-30%, and since the compiler only spends ~10% of the time in the allocator it shouldn't be that bad. It's really nice because it will mean sized deallocation errors get caught by the no optimization bots, along with lots of other checks like making sure all pointers passed to the API are within the bounds of a valid chunk + junk filling of all deallocated memory. |
|
Sounds good to me! |
bors
added a commit
that referenced
this pull request
Sep 9, 2014
The performance hit from these checks is significant, but unoptimized builds are already incredibly slow. Enabling these checks results in better test coverage since there are bots doing unoptimized builds, and the cost is relatively small in the context of an unoptimized build. This also allows using `JEMALLOC_FLAGS` to override the default configure flags.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
ide: improve ReferenceCategoryType It is bitset semantically --- many categorical things can be true about a reference at the same time. In parciular, a reference can be a "test" and a "write" at the same time.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
ide: improve ReferenceCategoryType It is bitset semantically --- many categorical things can be true about a reference at the same time. In parciular, a reference can be a "test" and a "write" at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance hit from these checks is significant, but unoptimized
builds are already incredibly slow. Enabling these checks results in
better test coverage since there are bots doing unoptimized builds, and
the cost is relatively small in the context of an unoptimized build.
This also allows using
JEMALLOC_FLAGSto override the defaultconfigure flags.