Make Int inherit from Ord. #18795
Merged
Make Int inherit from Ord. #18795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Int inherited from PartialOrd (via Primitive) but not Ord. But integers have a total order, so inheriting from Ord is appropriate. Fixes #18776.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. |
|
Thanks! |
bors
added a commit
that referenced
this pull request
Nov 10, 2014
Previously Int inherited from PartialOrd (via Primitive) but not Ord. But integers have a total order, so inheriting from Ord is appropriate. Fixes #18776.
There are some notes in the wiki about usage of "bors": |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 7, 2025
Fix render of literal to be rendered in codeblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Int inherited from PartialOrd (via Primitive)
but not Ord. But integers have a total order, so
inheriting from Ord is appropriate. Fixes #18776.