Add a doctest for the btreemap's entry method. #20134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| /// }, | ||
| /// } | ||
| /// } | ||
| /// ``` |
There was a problem hiding this comment.
Can you add an assert for e.g. the count of "a"?
There was a problem hiding this comment.
@gankro Is it appropriate to do something as simple as:
assert_eq!(*count.get("a").unwrap(), 3u);
There was a problem hiding this comment.
You should be able to even do:
assert_eq!(count["a"], 3);
Make some updates to the entry doctest.
jbranchaud
force-pushed
the
add-doctest-for-btreemap-entry
branch
from
ee7701a to
e8fcbfb
Compare
|
Thanks for the feedback! Updated. |
| /// } | ||
| /// } | ||
| /// | ||
| /// assert_eq!(count["a"], 3u); |
There was a problem hiding this comment.
Either this u can be omitted, or the whole type of count can-- I think. Your call.
|
Oh heh, should've refreshed the whole PR. No worries, not actually a big deal. :) Thanks! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 22, 2014
…entry This is an updated version of rust-lang#19711. The merge and subsequent rebase on that branch were more trouble than they were worth, so I am just resubmitting the relevant change here. If this PR is accepted, then rust-lang#19711 can be closed. /cc @gankro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #19711. The merge and subsequent rebase on that branch were more trouble than they were worth, so I am just resubmitting the relevant change here.
If this PR is accepted, then #19711 can be closed.
/cc @gankro