Fix Unicode name mangling #21544
Merged
Fix Unicode name mangling #21544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ 2beda41 thanks! |
| '~' => result.push_str("$UP$"), | ||
| '*' => result.push_str("$RP$"), | ||
| '&' => result.push_str("$BP$"), | ||
| '*' => result.push_str("$BP$"), |
|
⌛ Testing commit 2beda41 with merge ff21307... |
|
💔 Test failed - auto-mac-32-opt |
`{` and `}` aren’t valid characters on ARM.
This also fixes a small bug where `)` (**r**ight **p**arenthesis) and `*`
(**r**aw **p**ointer) would both mangle to `$RP$`, making `)` show up as `*` in
backtraces.
ftxqxd
force-pushed
the
mangle-unicode
branch
from
2beda41 to
cfe18fb
Compare
|
I only just realised that the previous failure was legitimate… The tests should pass now. r? @alexcrichton |
bors
added a commit
that referenced
this pull request
Feb 4, 2015
`{` and `}` aren’t valid characters on ARM, so this makes Unicode characters render as, e.g., `$u38d$` instead of `$u{38d}`.
This also fixes a small bug where `)` (**r**ight **p**arenthesis) and `*` (**r**aw **p**ointer) would both mangle to `$RP$`, making `)` show up as `*` in backtraces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{and}aren’t valid characters on ARM, so this makes Unicode characters render as, e.g.,$u38d$instead of$u{38d}.This also fixes a small bug where
)(right parenthesis) and*(raw pointer) would both mangle to$RP$, making)show up as*in backtraces.