Skip to content

Add two examples for Path::new #24649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2015
Merged

Add two examples for Path::new #24649

merged 3 commits into from
Apr 25, 2015

Conversation

nham
Copy link
Contributor

@nham nham commented Apr 21, 2015

No description provided.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

Thanks for this! A few nits inline:

@@ -1248,6 +1248,13 @@ impl Path {
/// use std::path::Path;
///
/// Path::new("foo.txt");
///
/// // Strings work too
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a or colon at the end of this sentence

@steveklabnik
Copy link
Member

Just some nits! see http://doc.rust-lang.org/nightly/book/documentation.html for some examples of the style

@nham
Copy link
Contributor Author

nham commented Apr 21, 2015

Sorry, I'm a bit confused on how to add the triple backticks. If these get split into multiple code blocks, will I have to import std::path::Path for each?

@steveklabnik
Copy link
Member

@nham sorry i missed this notification! This looks great though, thanks.

(and yes, you'd have to import each time, they're totally separate examples.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 25, 2015

📌 Commit ba4d55d has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 25, 2015
bors added a commit that referenced this pull request Apr 25, 2015
@bors
Copy link
Collaborator

bors commented Apr 25, 2015

⌛ Testing commit ba4d55d with merge de37e90...

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 25, 2015
@bors
Copy link
Collaborator

bors commented Apr 25, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Collaborator

bors commented Apr 25, 2015

⌛ Testing commit ba4d55d with merge f1328ba...

@bors
Copy link
Collaborator

bors commented Apr 25, 2015

⛄ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request Apr 25, 2015
@bors bors merged commit ba4d55d into rust-lang:master Apr 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants