-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add two examples for Path::new #24649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Thanks for this! A few nits inline: |
@@ -1248,6 +1248,13 @@ impl Path { | |||
/// use std::path::Path; | |||
/// | |||
/// Path::new("foo.txt"); | |||
/// | |||
/// // Strings work too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a or colon at the end of this sentence
Just some nits! see http://doc.rust-lang.org/nightly/book/documentation.html for some examples of the style |
Sorry, I'm a bit confused on how to add the triple backticks. If these get split into multiple code blocks, will I have to import |
@nham sorry i missed this notification! This looks great though, thanks. (and yes, you'd have to import each time, they're totally separate examples. |
@bors: r+ rollup |
📌 Commit ba4d55d has been approved by |
⛄ The build was interrupted to prioritize another pull request. |
⌛ Testing commit ba4d55d with merge f1328ba... |
⛄ The build was interrupted to prioritize another pull request. |
No description provided.