Skip to content

Typo in ownership.md #25188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2015
Merged

Typo in ownership.md #25188

merged 2 commits into from
May 10, 2015

Conversation

tincann
Copy link
Contributor

@tincann tincann commented May 7, 2015

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

@bors: r+ 4d1e48e rollup

Thanks!

@steveklabnik
Copy link
Member

Just beat me to it @alexcrichton :) thanks!

@tincann
Copy link
Contributor Author

tincann commented May 7, 2015

It's not much, but you're welcome. Quite enjoying the documentation style. Very easy to read.

@tshepang
Copy link
Member

tshepang commented May 9, 2015

Needs an r+

@tincann next time just create a separate Issue if the current one has been approved.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 10, 2015

📌 Commit ae1b2f4 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 10, 2015
@steveklabnik
Rollup merge of rust-lang#25188 - tincann:patch-1, r=steveklabnik
49a2cc7
@steveklabnik steveklabnik mentioned this pull request May 10, 2015
Closed
bors added a commit that referenced this pull request May 10, 2015
@bors
Auto merge of #25275 - steveklabnik:rollup, r=steveklabnik
d9ec142 
- Successful merges: #24948, #25085, #25158, #25188, #25239, #25240, #25241, #25255, #25257, #25263, #25271
- Failed merges:
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 10, 2015
@steveklabnik
Rollup merge of rust-lang#25188 - tincann:patch-1, r=steveklabnik
a725378
@steveklabnik steveklabnik mentioned this pull request May 10, 2015
Merged
bors added a commit that referenced this pull request May 10, 2015
@bors
Auto merge of #25281 - steveklabnik:rollup, r=steveklabnik
9ecc989 
- Successful merges: #24948, #25158, #25188, #25222, #25239, #25240, #25241, #25255, #25257, #25263
- Failed merges:
@bors bors merged commit ae1b2f4 into rust-lang:master May 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tincann @rust-highfive @alexcrichton @steveklabnik @tshepang @bors