Skip to content

rustfmt librustc_trans/save #28698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2015
Merged

rustfmt librustc_trans/save #28698

merged 2 commits into from
Oct 6, 2015

Conversation

nrc
Copy link
Member

@nrc nrc commented Sep 27, 2015

No description provided.

@rust-highfive
Copy link
Contributor

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)

nrc
nrc reviewed Sep 27, 2015
View reviewed changes
src/librustc_trans/save/span_utils.rs
}

// Standard string for extents/location.
#[rustfmt_skip]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nrc/rustfmt/issues/389

@nrc
Copy link
Member Author

nrc commented Sep 28, 2015

The fail just needs to allow unknown attributes - an easy fix, so I'll wait for review first

@nrc
Copy link
Member Author

nrc commented Sep 28, 2015

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned jroesch Sep 28, 2015
@brson
Copy link
Contributor

brson commented Sep 30, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 30, 2015

📌 Commit 6784c41 has been approved by brson

@bors
Copy link
Collaborator

bors commented Sep 30, 2015

⌛ Testing commit 6784c41 with merge d482ed8...

@bors
Copy link
Collaborator

bors commented Sep 30, 2015

💔 Test failed - auto-linux-64-x-android-t

@bors
Copy link
Collaborator

bors commented Oct 1, 2015

☔ The latest upstream changes (presumably #28746) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc
Copy link
Member Author

nrc commented Oct 5, 2015

@bors: r=brson

@bors
Copy link
Collaborator

bors commented Oct 5, 2015

📌 Commit 970639a has been approved by brson

@bors
Copy link
Collaborator

bors commented Oct 6, 2015

⌛ Testing commit 970639a with merge ea721d9...

@nrc
Copy link
Member Author

nrc commented Oct 6, 2015

@bors: r=brson

@bors
Copy link
Collaborator

bors commented Oct 6, 2015

📌 Commit b22231c has been approved by brson

@bors
Copy link
Collaborator

bors commented Oct 6, 2015

⌛ Testing commit b22231c with merge 3729b12...

bors added a commit that referenced this pull request Oct 6, 2015
@bors
Auto merge of #28698 - nrc:fmt8, r=brson
3729b12
@bors
Copy link
Collaborator

bors commented Oct 6, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit b22231c into rust-lang:master Oct 6, 2015
@bors bors mentioned this pull request Oct 6, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nrc @rust-highfive @brson @bors @jroesch