New path of method offset

[therustmonk]

No description provided.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[alexcrichton]

Thanks! I think this is referring to this function, and while ptr::offset may not be 100% correct I think it's probably a little more right than pointer::offset. Perhaps this could be <*mut T>::offset?

[therustmonk]

I guess you were right! But there is also * const. Which implementation to prefer? All roads leads to intrinsics::offset. But <T> hints at the size, it's better. Do you want I'll rebase it to <*mut T>::offset?

[alexcrichton]

Yeah seems fine to mention *const as well, it's basically just saying the offset method on raw pointers (which would also be fine to just say in words)

[therustmonk]

What do you think about this explanation? I think it don't incite reader to search a non existent qualified path.

[alexcrichton]

@bors: r+ 5736c1d

Looks good to me!

[bors]

⌛ Testing commit 5736c1d with merge be91042...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt