Reinstate while loop in deaggregator pass #38265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
The diff is very small when ignoring whitespace: https://github.com/rust-lang/rust/pull/38265/files?w=1 cc @scottcarr as previous author of the pass. |
|
Note: This is just fixing logic errors for a pass that is (so far) disabled by default. This was like the first step to be able to work on other things close to this pass. |
|
This looks correct to me. r+. |
|
@bors r=nagisa |
|
📌 Commit e3526af has been approved by |
A previous commit must have removed the `while let` loop here by mistake; for each basic block, it should find and deaggregate multiple statements in their index order, and the `curr` index tracks the progress through the block. This fixes both the case of deaggregating statements in separate basic blocks (preserving `curr` could prevent that) as well as multiple times in the same block (missing loop prevented that).
bluss
force-pushed
the
mir-deaggregator-loop
branch
from
e3526af to
fbc3f11
Compare
|
Amended to fix a tidy failure (line longer than 100) |
|
@bors r=nagisa |
|
📌 Commit fbc3f11 has been approved by |
|
⌛ Testing commit fbc3f11 with merge 8f66e55... |
|
💔 Test failed - auto-linux-32-opt |
|
⌛ Testing commit fbc3f11 with merge 3db197a... |
bors
added a commit
that referenced
this pull request
Dec 11, 2016
Reinstate while loop in deaggregator pass A previous commit must have removed the `while let` loop here by mistake; for each basic block, it should find and deaggregate multiple statements in their index order, and the `curr` index tracks the progress through the block. This fixes both the case of deaggregating statements in separate basic blocks (preserving `curr` could prevent that) as well as multiple times in the same block (missing loop prevented that). The loop was lost in commit bda46c2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit must have removed the
while letloop here bymistake; for each basic block, it should find and deaggregate multiple
statements in their index order, and the
currindex tracks theprogress through the block.
This fixes both the case of deaggregating statements in separate
basic blocks (preserving
currcould prevent that) as wellas multiple times in the same block (missing loop prevented that).
The loop was lost in commit bda46c2.