-
Notifications
You must be signed in to change notification settings - Fork 13.3k
deriv(Hash) for single-variant enum should not hash discriminant #42709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
r? @jseyfried |
@jseyfried This is waiting for a review from you, and possibly should get sign off from @rust-lang/libs as well - I don't think if this change is something we want to commit to. Seems fine to me, though. |
Reviewed, r=me if @rust-lang/libs is OK with the new behavior (I don't have a strong opinion either way). |
@bors: r=jseyfried Yeah libs-wise this is fine |
📌 Commit f11e40a has been approved by |
deriv(Hash) for single-variant enum should not hash discriminant Fixes #39137
☀️ Test successful - status-appveyor, status-travis |
Reopened. |
@kryptan yes, sorry. |
Fixes #39137