Skip to content

deriv(Hash) for single-variant enum should not hash discriminant #42709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

stepancheg
Copy link
Contributor

Fixes #39137

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2017
@arielb1
Copy link
Contributor

arielb1 commented Jun 20, 2017

r? @jseyfried

@Mark-Simulacrum
Copy link
Member

@jseyfried This is waiting for a review from you, and possibly should get sign off from @rust-lang/libs as well - I don't think if this change is something we want to commit to. Seems fine to me, though.

@jseyfried
Copy link
Contributor

Reviewed, r=me if @rust-lang/libs is OK with the new behavior (I don't have a strong opinion either way).

@alexcrichton
Copy link
Member

@bors: r=jseyfried

Yeah libs-wise this is fine

@bors
Copy link
Collaborator

bors commented Jun 27, 2017

📌 Commit f11e40a has been approved by jseyfried

@bors
Copy link
Collaborator

bors commented Jun 28, 2017

⌛ Testing commit f11e40a with merge 5bc8941...

bors added a commit that referenced this pull request Jun 28, 2017
deriv(Hash) for single-variant enum should not hash discriminant

Fixes #39137
@bors
Copy link
Collaborator

bors commented Jun 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: jseyfried
Pushing 5bc8941 to master...

@bors bors merged commit f11e40a into rust-lang:master Jun 28, 2017
@kryptan
Copy link
Contributor

kryptan commented Jun 28, 2017

I don't think this PR fixes #39137.

#39137 is about enums marked with repr(u8) (or other similar reprs). This PR affects enums with single variant regardless of their repr.

@Mark-Simulacrum
Copy link
Member

Reopened.

@stepancheg
Copy link
Contributor Author

@kryptan yes, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants