use param_env on the trait_cache key #44741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 03d9056 has been approved by |
nikomatsakis
requested changes
Sep 21, 2017
| @@ -33,22 +33,22 @@ impl<'a, 'tcx> TyCtxt<'a, 'tcx, 'tcx> { | |||
| /// obligations *could be* resolved if we wanted to. | |||
There was a problem hiding this comment.
Nit: Can we extend this comment to say "/// Assumes that this is run after the entire crate has been successfully type-checked."
|
@bors: r=nikomatsakis |
|
📌 Commit a7e302a has been approved by |
alexcrichton
added
the
S-waiting-on-bors
|
⌛ Testing commit a7e302a33a634fdbadd01b71f97d964b3a6b31f4 with merge b88c670c31bd47a19d5cd788a1e5d7ab8e54d6f8... |
|
💔 Test failed - status-travis |
|
Needs to submit a PR to miri, and set miri's toolstate to "Broken". (cc @oli-obk @RalfJung @eddyb) |
qmx
force-pushed
the
trans_fulfill_obligation_should_not_crash
branch
from
f7da45f to
9d52cb2
Compare
|
@bors r+ |
|
📌 Commit 9d52cb2 has been approved by |
nikomatsakis
approved these changes
Sep 25, 2017
bors
added a commit
that referenced
this pull request
Sep 26, 2017
… r=nikomatsakis use param_env on the trait_cache key We bailed from making trans_fulfill_obligation return `Option` or `Result`, just made it less prone to crashing outside trans r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bailed from making trans_fulfill_obligation return
OptionorResult, just made it less prone to crashing outside transr? @nikomatsakis