Clean up some mir transform passes #75503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a few places where there were intermediates being created in MIR optimization passes, so I removed them.
rust-highfive
added
the
S-waiting-on-review
JulianKnodt
force-pushed
the
opt_opt
branch
2 times, most recently
from
6405cf0 to
510c3ae
Compare
JulianKnodt
commented
Aug 14, 2020
| TerminatorKind::FalseUnwind { real_target, unwind } | ||
| if predicate(real_target) && unwind.map_or(true, &predicate) => | ||
| { | ||
| TerminatorKind::Unreachable |
There was a problem hiding this comment.
I also added these, not sure if they're viable or not.
JulianKnodt
force-pushed
the
opt_opt
branch
2 times, most recently
from
baf7f1e to
ff6bd95
Compare
|
I realize this is a lot of changes, and I can split it into separate PRs, but curious whether this sort of change would be accepted. (And also open to accepting in current form) |
JulianKnodt
force-pushed
the
opt_opt
branch
2 times, most recently
from
f34c767 to
5e9d088
Compare
oli-obk
reviewed
Aug 14, 2020
|
@bors r+ rollup=never Yea I don't think this'll have measurable perf implications, but let's not roll it up to be sure |
|
📌 Commit 5e9d088b23743145ee0b54557627f29f7ec962e3 has been approved by |
bors
added
S-waiting-on-bors
|
Ah I just pushed the change to convert from |
oli-obk
reviewed
Aug 14, 2020
Also convert `uninhabited_enum_branching` `Cow<[u128]>::to_mut`
|
@bors r+ |
|
📌 Commit fd63bf7 has been approved by |
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few places where there were intermediates being created
in MIR optimization passes, so I removed them.
I also changed some
Some(..)into just..and wrapSome(..)at the function end, doing early returns forNone.I was generally looking for some easy optimizations in theses passes, and hopefully these should improve the runtime of these passes by a tinnnyyyyy bit.
r? @oli-obk