Removes debug settings from wasm32_unknown_emscripten default link args #97928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a debug setting. We should only make debug builds if user requests a debug build. Currently this is inserted in release builds. Furthermore, it would be better to insert these settings in --pre-link-args because then it would be possible to override them if appropriate. Because these are inserted at the end, it is necessary to patch emscripten to remove them.
rustbot
added
the
T-compiler
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
|
rust-highfive
added
the
S-waiting-on-review
sbc100
reviewed
Jun 9, 2022
This comment has been minimized.
This comment has been minimized.
sbc100
reviewed
Jun 9, 2022
tlively
approved these changes
Jun 9, 2022
|
@bors r=tlively rollup |
|
📌 Commit b32238a has been approved by |
bors
added
S-waiting-on-bors
|
Title says: |
Dylan-DPC
changed the title
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 10, 2022
…r=tlively Removes debug settings from wasm32_unknown_emscripten default link args This is a debug setting. We should only make debug builds if user requests a debug build. Currently this is inserted in release builds. Furthermore, it would be better to insert these settings in --pre-link-args because then it would be possible to override them if appropriate. Because these are inserted at the end, it is necessary to patch emscripten to remove them. `@sbc100`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 10, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#93331 (refactor write_output_file to merge two invocation paths into one.) - rust-lang#97928 (Removes debug settings from wasm32_unknown_emscripten default link args) - rust-lang#97940 (Use relative links instead of linking to doc.rust-lang.org when possible) - rust-lang#97941 (nit: Fixed several error_codes/Exxxx.md messages which used UpperCamelCase…) - rust-lang#97953 (Add regression test for rust-lang#54378) - rust-lang#97957 (Make `std::` prefix suggestion test `run-rustfix`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
workingjubilee
added
the
O-emscripten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a debug setting. We should only make debug builds if user requests
a debug build. Currently this is inserted in release builds.
Furthermore, it would be better to insert these settings in --pre-link-args
because then it would be possible to override them if appropriate. Because
these are inserted at the end, it is necessary to patch emscripten to remove
them.
@sbc100