-
Notifications
You must be signed in to change notification settings - Fork 544
Introduce a normalization chapter #2266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+311
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshepang
reviewed
Mar 15, 2025
BoxyUwU
commented
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
lcnr
reviewed
Apr 29, 2025
b78a060
to
423298c
Compare
@BoxyUwU I just read through this and I wanted to just let you know that this is awesome. |
Thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: this PR is waiting for a reviewer to verify its content
T-types
Relevant to types team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kind of just asborbed the new solver normalization chapter into this one because it was super out of date and seemed better to move what bits of information it had that were still correct somewhere alongside all the other norm information.
There's some lost information around the exactly impl details of the new solver 🤔 In general I would like to cover more impl details in this chapter butr I think this is a sufficiently large first step 😆