add trim to avoid internal error #3905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
suggested changes
Nov 6, 2019
src/visitor.rs
Outdated
| @@ -248,6 +248,7 @@ impl<'b, 'a: 'b> FmtVisitor<'a> { | |||
|
|
|||
| for (kind, offset, sub_slice) in CommentCodeSlices::new(self.snippet(span)) { | |||
| let sub_slice = transform_missing_snippet(config, sub_slice); | |||
| let sub_slice = sub_slice.trim(); | |||
There was a problem hiding this comment.
I cannot come up with an example, though I am afraid that this could potentially break the code by trimming newlines from the subslice. E.g., we call sub_slice.find("\n") below to figure out whether the code should sit on the same line or the next line.
The safer approach would be to not call rewrite_comment when the other_lines.trim() is an empty string.
https://github.com/rust-lang/rustfmt/pull/3905/files#diff-85974d8eb6610bd6ea773d375ad8c6d2R283-R290
There was a problem hiding this comment.
Thank you for the review. I fixed it. I also added the trim for version one logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3904