Skip to content

Running multirust installer hangs on Windows #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Oct 8, 2015 · 6 comments
Closed

Running multirust installer hangs on Windows #6

alexcrichton opened this issue Oct 8, 2015 · 6 comments

Comments

@alexcrichton
Copy link
Member

For example:

$ multirust
This is the currently installed multirust binary.

(and it never returns to the shell). If I hit "enter" it'll return, but perhaps shouldn't require that? I also ran into this when installing or maybe updating a toolchain, but I forget the precise situation.
@Diggsey
Copy link
Contributor

Diggsey commented Oct 8, 2015

This is intentional: when run with no arguments it will wait for input before exiting in case it wasn't run from a terminal. The alternative results in momentarily flashing up a terminal which disappears before you can read the message, if the program is run directly.

It should never happen when installing or updating a toolchain.

@alexcrichton
Copy link
Member Author

Ah ok, I find this surprising but if it's intentional I'll close.

@alexcrichton alexcrichton changed the title Running "multirust" on Windows hangs Running multirust installer hangs on Windows Oct 9, 2015
@alexcrichton
Copy link
Member Author

Ah ok so I just ran the installer and after it printed "info: Installed" it ended up hanging waiting for more data, so that's at least a reproduction!

@alexcrichton alexcrichton reopened this Oct 9, 2015
@Diggsey
Copy link
Contributor

Diggsey commented Oct 9, 2015

Oh, I phrased that ambiguously. It should be read as "It should never happen when (installing or updating) a toolchain". ie, It will happen when installing multirust itself, as that's precisely the case where it needs to stick around in case it's been run directly from the browser or filesystem, and so the terminal would otherwise disappear.

If you can think of a better way to handle this, I'll keep the issue open as a feature request.

@alexcrichton
Copy link
Member Author

Oh... interesting... I would expect 99% of users to work with multirust from a CLI, not from a GUI (e.g. it's a power user tool)

@Diggsey
Copy link
Contributor

Diggsey commented Oct 9, 2015

Right, but typically you would download multirust using one of the binary links in the readme, and it would be very confusing if after downloading and running the installer, you answered the two questions and then the terminal just disappeared, with no indication that it had been installed.

@Diggsey Diggsey closed this as completed Oct 11, 2015
@kevinpoitra kevinpoitra mentioned this issue Apr 5, 2016
Open
@erde74 erde74 mentioned this issue Aug 15, 2016
Closed
djc added a commit that referenced this issue Jun 18, 2024
@djc
# This is a combination of 40 commits.
97dd0be 
# This is the 1st commit message:

Port cli_inst_interactive to CliTestContext

# The commit message #2 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #3 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #4 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #5 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #6 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #7 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #8 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #9 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #10 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #11 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #12 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #13 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #14 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #15 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #16 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #17 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #18 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #19 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #20 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #21 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #22 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #23 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #24 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #25 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #26 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #27 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #28 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #29 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #30 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #31 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #32 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #33 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #34 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #35 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #36 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #37 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #38 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #39 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #40 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext
djc added a commit that referenced this issue Jun 18, 2024
@djc
# This is a combination of 19 commits.
f9d90a3 
# This is the 1st commit message:

Port cli_misc to CliTestContext

# The commit message #2 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #3 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #4 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #5 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #6 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #7 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #8 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #9 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #10 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #11 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #12 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #13 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #14 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #15 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #16 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #17 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #18 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #19 will be skipped:

# fixup! Port cli_misc to CliTestContext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @Diggsey