Skip to content

Stabilize __m512i, __m512, and __m512d #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented May 31, 2023

While there might be some uncertainty still with all the intrinsics and other related items, could we perhaps stabilize the types?

It seems like there's not much choice to be had, since m512 is definitely f32x16 and m512d is likewise f64x8.

I didn't include __m512bh since __m128bh is also unstable.

https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/Stabilizing.20AVX2.20.26.20AVX512.20*types*/near/362541037

I didn't include `__m512bh` since `__m128bh` is also unstable.
@rustbot
Copy link
Collaborator

rustbot commented May 31, 2023

r? @Amanieu

(rustbot has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented May 31, 2023

These types are independently useful even without the intrinsics since they can be used with inline assembly.

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented May 31, 2023

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@scottmcm
Copy link
Member Author

scottmcm commented Jun 2, 2023

FYI @dtolnay, it looks from the edit history like you attempted to check a box, but somehow rfcbot then removed your checkmark?

@rfcbot
Copy link

rfcbot commented Jun 3, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @Amanieu, I wasn't able to add the final-comment-period label, please do so.

@rfcbot
Copy link

rfcbot commented Jun 13, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

psst @Amanieu, I wasn't able to add the finished-final-comment-period label, please do so.

@Amanieu Amanieu merged commit d77878b into rust-lang:master Jun 13, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 17, 2023
Bump stdarch

In particular to pick up the stabilization of the AVX512 types (but not intrinsics) that was FCPed in rust-lang/stdarch#1436.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 17, 2023
Bump stdarch

In particular to pick up the stabilization of the AVX512 types (but not intrinsics) that was FCPed in rust-lang/stdarch#1436.
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Jun 18, 2023
Bump stdarch

In particular to pick up the stabilization of the AVX512 types (but not intrinsics) that was FCPed in rust-lang/stdarch#1436.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Aug 24, 2023
Bump stdarch

In particular to pick up the stabilization of the AVX512 types (but not intrinsics) that was FCPed in rust-lang/stdarch#1436.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants