Add option to disable network tests #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo xtask run` now takes a `--disable-network` arg that turns off the network protocol tests by not creating a network device. The purpose of this flag is to make the QEMU tests faster when iterating on something locally. Disabling the network stuff drops the time down from ~12.5s to ~4.5s. The extra time doesn't matter when running in CI, but for quick local testing it can add up.
phip1611
force-pushed
the
bishop-optional-net
branch
from
db3cdba to
10de8de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo xtask runnow takes a--disable-networkarg that turns off the network protocol tests by not creating a network device.The purpose of this flag is to make the QEMU tests faster when iterating on something locally. Disabling the network stuff drops the time down from ~12.5s to ~4.5s. The extra time doesn't matter when running in CI, but for quick local testing it can add up.
Checklist
Rewriting History guide for
help.