Undefined behavior in renderdoc crate #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebkalderon
changed the title
|
@Shnatsel I am also working on publishing a security advisory on GitHub as well. If you would like to join as a collaborator to review the advisory text, I would be happy to add you. |
tarcieri
reviewed
Sep 2, 2019
|
Thanks for the review, @tarcieri! |
|
Assigned |
|
The corresponding GitHub security advisory has been published here: GHSA-4mmc-49vf-jmcp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating the renderdoc-rs bindings a few months ago, I had identified several methods that were taking immutable reference to
selfbut were actually making internally mutating RenderDoc API calls, which could potentially lead to undefined behavior.This issue was corrected in the 0.5.0 release, and it was recently suggested that I file a public advisory here, which was a very good idea.
I would appreciate any feedback in reporting this advisory properly, and I hope to report any such cases in a more timely manner in the future.