fix: added support for merging items into an existing array #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR makes the following changes:
set
with another object are merged. Previous behaviour was to do nothing. There is a comment indicating merging was perhaps being considered but the action was left unhandled.set
function could clear items adjacent to the element being set. This feels undesirable as the set operation is altering part of the object outside of the path that is being targeted. That should no longer happen.The changes don't break any of the existing tests which lead me to believe they just haven't been accomodated for. Below shows the newly added tests which fail when run against the code in the
main
branch.Hopefully this can be accepted. Please let me know if anything more is needed to get this merged and released.
Thanks!