Skip to content

FOSWEC Example #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

FOSWEC Example #402

wants to merge 2 commits into from

Conversation

jtgrasb
Copy link
Collaborator

@jtgrasb jtgrasb commented Apr 2, 2025

Description

This PR builds off of PR #214 and my analysis of the FOSWEC and comparison to tank test data. Since we already have 4 examples, it may be too much to add a 5th, but there are some unique features that could be included in this example:

  • Comparison of BEM and hydrostatic data to experimental data to validate hydrodynamic/impedance model
  • Animation of Capytaine degrees of freedom
  • Consideration of a multi-dof coupled PTO
  • Nonlinear hydrostatics and excitation
  • Capacity factor design study

Type of PR

  • New Example

@coveralls
Copy link

coveralls commented Apr 2, 2025

Pull Request Test Coverage Report for Build 14229600031

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 94.514%

Files with Coverage Reduction New Missed Lines %
wecopttool/core.py 2 92.68%
Totals Coverage Status
Change from base Build 13461798908: -0.07%
Covered Lines: 2774
Relevant Lines: 2935

💛 - Coveralls

@rgcoe rgcoe mentioned this pull request Apr 24, 2025
7 tasks
@rgcoe rgcoe added the documentation Improvements or additions to documentation label May 8, 2025
@rgcoe
Copy link
Collaborator

rgcoe commented May 8, 2025

While I am generally against adding more examples, I agree this is one we should consider - let's discuss as a group.

@rgcoe
Copy link
Collaborator

rgcoe commented May 8, 2025

Per discussion today, this is definitely something we will aim to include, but want to get MIMO control working properly (see #281, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants