Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spring 4.2.1 → 4.3.0 (minor) #936

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 13, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ spring (4.2.1 → 4.3.0) · Repo · Changelog

Release Notes

4.3.0 (from changelog)

  • Fix reloading issue in Ruby 3.3.
  • Fixed compatibility with --enable-frozen-string-literal.
  • Add embeded engines to default reload matcher.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 9 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added dependencies Pull requests that update a dependency file Technical debt Technical debt labels Mar 13, 2025
@yoldas
Copy link
Member

yoldas commented Mar 25, 2025

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/spring-4.3.0 branch from 3e120e9 to b82d06d Compare March 25, 2025 17:19
@yoldas yoldas self-assigned this Mar 25, 2025
@yoldas
Copy link
Member

yoldas commented Mar 25, 2025

Error in console does not show the fix merged in develop after the rebase. Try recreating it.

@yoldas
Copy link
Member

yoldas commented Mar 25, 2025

@depfu recreate

@depfu depfu bot force-pushed the depfu/update/spring-4.3.0 branch from b82d06d to b0d59c4 Compare March 25, 2025 17:34
@yoldas
Copy link
Member

yoldas commented Mar 25, 2025

Add expectations (URL change) before record counts to avoid flaky behaviour, i.e. capybara will spend default_max_wait_time to check the URL change and then record count will happen. In this case, the URL change means the end of database write so record count should return the correct result.

@yoldas yoldas merged commit 025df9f into develop Mar 25, 2025
4 checks passed
@depfu depfu bot deleted the depfu/update/spring-4.3.0 branch March 25, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Technical debt Technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant