Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Update rubocop-rails 2.26.2 → 2.30.3 (minor) #4788

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 27, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.26.2 → 2.30.3) · Repo · Changelog

Release Notes

2.30.3

Bug fixes

  • #1458: Fix a false positive for Rails/RelativeDateConstant when assigning a lambda/proc with numblock. (@earlopain)
  • #1457: Fix a false positive for Rails/ReversibleMigration in drop_table with numblock. (@earlopain)
  • #1456: Fix a false positive for Rails/CreateTableWithTimestamps with numblocks. (@earlopain)
  • #1459: Fix a false positive for Rails/UniqBeforePluck when using a numblock with uniq. (@earlopain)
  • #1455: Make Rails/SaveBang aware of numblocks. (@earlopain)
  • #1453: Make Rails/TransactionExitStatement aware of numblocks. (@earlopain)

Changes

  • #1179: Rails/ReflectionClassName: Accept method calls on local variables. (@exterm)
  • #1385: Make Lint/UselessAccessModifier aware of ActiveSupport::Concern and Module#concerning/Module#concern core extensions. (@earlopain)
  • #1454: Disable Rails/Delegate for controllers. (@earlopain)

2.30.2

Bug fixes

  • #1447: Fix false positive for Rails/LexicallyScopedActionFilter when action methods are delegated. (@vlad-pisanov)
  • #1446: Fix false positives for Rails/Delegate when module_function is used. (@ydakuka)
  • #1427: Fix an error for Rails/UniqBeforePluck when pluck and unique are on different lines. (@earlopain)

2.30.1

Bug fixes

  • #1442: Fix an incorrect behavior when using AllCops: TargetRailsVersion. (@koic)
  • #1444: Fix an incorrect behavior when using AllCops: MigratedSchemaVersion. (@koic)

2.30.0

New features

Bug fixes

  • #1071: Fix Rails/FilePath cop to correctly handle File.join with variables and ignore leading and multiple slashes in string literal arguments for Rails.root.join and File.join. (@ydakuka)
  • #912: Enhance Rails/Delegate by adding delegation detection for self.class, constants, class variables, global variables, and instance variables. (@ydakuka)

2.29.1

Bug fixes

  • #1423: Fix an error for Rails/StrongParametersExpect when using permit with no arguments. (@koic)
  • #1417: Fix an incorrect autocorrect for Rails/StrongParametersExpect when using a leading dot multiline call to require with permit. (@koic)
  • #1356: Enhance Rails/DuplicateAssociation to handle alias. (@ydakuka)
  • #1389: Handle TypeError caused by passing array literals as arguments to File methods in Rails/FilePath cop. (@ydakuka)
  • #1389: Handle TypeError caused by passing array literals as arguments to File methods in Rails/RootPathnameMethods cop. (@ydakuka)
  • #1228: Enhance Rails/SaveBang to properly handle instance variables. (@ydakuka)

2.29.0

New features

  • #1407: Add new Rails/MultipleRoutePaths cop. (@koic)
  • #1358: Add new Rails/StrongParametersExpect cop. (@koic)

Bug fixes

  • #1409: Fix an error for Rails/ReversibleMigration when calling drop_table without any arguments. (@earlopain)
  • #1397: Fix an incorrect autocorrect for Rails/TimeZone when Time.new has a string argument. (@mterada1228)
  • #1406: Fix autocorrection for Rails/IndexBy and Rails/IndexWith when map { ... }.to_h is enclosed in another block. (@franzliedke, @eugeneius)
  • #1404: Update Rails/IndexBy and Rails/IndexWith to support numbered block parameters. (@eugeneius)
  • #1405: Fix autocorrection for Rails/IndexWith when the value is a hash literal without braces. (@koic, @eugeneius)
  • #1414: Fix Rails/HttpPositionalArguments cop false positives with arguments forwarding. (@viralpraxis)

Changes

  • #1410: Make registered cops aware of AllCops: MigratedSchemaVersion. (@koic)

2.28.0

New features

  • #1383: Introduce AllCops: MigratedSchemaVersion config. (@koic)

Bug fixes

  • #1390: Fix an incorrect autocorrect for Rails/SelectMap when select has no receiver and method chains are used. (@masato-bkn)
  • #1382: Fix false negatives for Rails/RedundantActiveRecordAllMethod when using all method in block. (@masato-bkn)
  • #1397: Fix Rails/FilePath cop error on join method with implicit receiver. (@viralpraxis)
  • #1398: Fix Rails/FilePath cop error in case of extra operations in Rails.root interpolation. (@viralpraxis)
  • #1392: Fix Rails/FilePath cop error with rescued Rails.root. (@viralpraxis)

Changes

  • #1388: Modify Rails/Pluck to ignore map/collect when used inside blocks to prevent potential N+1 queries. (@masato-bkn)

2.27.0

Bug fixes

  • #1377: Fix an error for Rails/EnumSyntax when positional arguments are used and options are not passed as keyword arguments. (@koic)
  • #1367: Fix Rails/TimeZone should not report offense on String#to_time with timezone specifier. (@armandmgt)

Changes

  • #727: Disable Rails/TransactionExitStatement on Rails >= 7.2. (@earlopain)
  • #1374: Change Rails/EnvLocal to handle negated conditions. (@fatkodima)
  • #1195: Change Rails/SelectMap to handle safe navigation operators. (@fatkodima)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ logger (1.6.6 → 1.7.0) · Repo

Sorry, we couldn't find anything useful about this release.

↗️ connection_pool (indirect, 2.4.1 → 2.5.0) · Repo · Changelog

Release Notes

2.5.0 (from changelog)

  • Reap idle connections [#187]
idle_timeout = 60
pool = ConnectionPool.new ...
pool.reap(idle_timeout, &:close)
  • ConnectionPool#idle returns the count of connections not in use [#187]

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 9 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the dependencies Pull requests that update a dependency file label Mar 27, 2025
@StephenHulme StephenHulme merged commit c61a034 into develop Mar 27, 2025
20 of 21 checks passed
@StephenHulme StephenHulme deleted the depfu/update/rubocop-rails-2.30.3 branch March 27, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant