Skip to content

Add support for scw on Linux arm64 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Add support for scw on Linux arm64 #465

merged 1 commit into from
Jun 7, 2017

Conversation

superseed
Copy link

This is a simple change to the Makefile to include linux/arm64 as a default target. I tried adding the darwin/arm64 version too, but it fails at the last step with a rather obscure error:

# github.com/scaleway/scaleway-cli/cmd/scw
warning: unable to find runtime/cgo.a
/usr/local/Cellar/go/1.8.3/libexec/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
ld: warning: ignoring file /var/folders/hy/_ppky1c912jfgvvh610qz5600000gn/T/go-link-289996183/go.o, file was built for unsupported file format ( 0xCF 0xFA 0xED 0xFE 0x0C 0x00 0x00 0x01 0x00 0x00 0x00 0x00 0x01 0x00 0x00 0x00 ) which is not the architecture being linked (x86_64): /var/folders/hy/_ppky1c912jfgvvh610qz5600000gn/T/go-link-289996183/go.o
Undefined symbols for architecture x86_64:
  "_main", referenced from:
     implicit entry/start for main executable
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Considering that darwin/arm64 is not critical, I think this can be merged as is, so we can use the newly created linux/arm64 binary to make an arm64 version of the image-builder.

@superseed superseed requested a review from brmzkw June 7, 2017 10:00
@coveralls
Copy link

Coverage Status

Coverage remained the same at 25.105% when pulling 9b8ac93 on arm64-target into f998a95 on master.

@QuentinPerez
Copy link
Contributor

LGTM

@brmzkw brmzkw merged commit d48bac1 into master Jun 7, 2017
@brmzkw brmzkw removed the in progress label Jun 7, 2017
@brmzkw brmzkw deleted the arm64-target branch June 7, 2017 13:19
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants