Adding functionality to pass a list to initialize FPS, so that you ca… #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n use previously fit values
Luthaf
reviewed
Aug 20, 2021
tests/test_feature_simple_fps.py
Outdated
| with self.subTest(initialize=initialize): | ||
| selector = FPS(n_to_select=1, initialize=initialize) | ||
| selector = FPS(n_to_select=len(self.idx) - 1, initialize=initialize) |
There was a problem hiding this comment.
I don't understand the len(self.idx) - 1 here. Why not 1?
tests/test_sample_simple_fps.py
Outdated
| @@ -31,9 +31,9 @@ def test_initialize(self): | |||
| and throws an error otherwise | |||
| """ | |||
|
|
|||
| for initialize in [self.idx[0], "random"]: | |||
| for initialize in [self.idx[0], "random", self.idx[:4]]: | |||
There was a problem hiding this comment.
we should also have a test that restarting from a list gives back the indexes as the first selected values
There was a problem hiding this comment.
I pulled the test for the initialize list out of this loop to simplify things (remove the need for len(idx) - 1) and add the additional check that the lists are the same.
Luthaf
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n use previously fit values
This should hopefully be a small PR -- I've added the necessary tests and update docs.
The purpose of this PR is to allow someone to fit an FPS selector for n features / samples, then use the results of that selector to initialize a new selector that is choosing m features. Use case is "I chose 1000 features, but now I need 1001!"