Skip to content

Allow selectors to select all available points #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

Allow selectors to select all available points #137

merged 1 commit into from
Jun 28, 2022

Conversation

Luthaf
Copy link
Collaborator

@Luthaf Luthaf commented Jun 20, 2022

I don't see a reason for limiting the number of points we can select to n_available - 1, especially since we can also request a fractional in the (0, 1] range

@Luthaf Luthaf requested a review from rosecers June 20, 2022 13:39
@rosecers rosecers merged commit 888395a into scikit-learn-contrib:main Jun 28, 2022
@Luthaf Luthaf deleted the select-all-points branch June 28, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosecers rosecers rosecers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luthaf @rosecers