Fixing negative distances for fitted points with the DirectionalConvexHull #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
changed the title
agoscinski
commented
Mar 10, 2023
skmatter/sample_selection/_base.py
Outdated
| @@ -399,6 +399,15 @@ def __init__( | |||
| ) | |||
|
|
|||
|
|
|||
| def directional_distance(equations, points): | |||
There was a problem hiding this comment.
Would be nice if we add here explanation for math. I did not find this trivial at all
skmatter/sample_selection/_base.py
Outdated
| @@ -565,17 +598,46 @@ def score_samples(self, X, y): | |||
|
|
|||
| # features used for the convex hull construction | |||
| low_dim_feats = X[:, self.low_dim_idx] | |||
| hull_space_feats = np.hstack((y.reshape(-1, 1), low_dim_feats)) | |||
There was a problem hiding this comment.
Should use "hull_space_data" for consistency with fit function
skmatter/sample_selection/_base.py
Outdated
| ] | ||
|
|
||
| self.selected_idx_ = np.unique(self.directional_simplices_.flatten()) | ||
| self.directional_points_ = convex_hull_data[self.selected_idx_] |
There was a problem hiding this comment.
Should probably be a hidden variable no?
| convex_hull.simplices[np.where(y_normal < 0)[0]].flatten() | ||
| ) | ||
| directional_facets_idx = np.where(y_normal < 0)[0] | ||
| self.directional_simplices_ = self.convex_hull_.simplices[ |
There was a problem hiding this comment.
should probably be a hidden variable, no?
victorprincipe
force-pushed
the
changing-dch-score-samples
branch
from
a9bc50c to
96a2596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #162
First commit adds a test that fails with the current way distances to the convex hull are computed in main, the second commit changes to a different way of computing the distances to the convex hull that run with the tests