[refactor] Always check program commitment in each proof generation #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-verifier
lispc
reviewed
Mar 11, 2025
| @@ -572,6 +587,9 @@ impl<Type: ProverType> Prover<Type> { | |||
| /// | |||
| /// [evm_proof][openvm_native_recursion::halo2::EvmProof] | |||
| fn gen_proof_snark(&self, task: &Type::ProvingTask) -> Result<EvmProof, Error> { | |||
| // sanity check | |||
| let _ = Self::get_verify_program_commitment(&self.app_committed_exe, &self.app_pk, false); | |||
|
|
|||
There was a problem hiding this comment.
you cannot pick commitments from StarkProof. But it is easy to pick from EvmProof? just instance[0][12] and instance[0][13]?
i want to also check that.
There was a problem hiding this comment.
in gen_proof_snark, i think we don't do this get_verify_program_commitment. just assert_eq commitments_in_evm_proof == Type::commitment
lispc
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can only get program commitment by
AppExecutionCommit::computeroute (or launch a verifcation progress)This PR make sanity check by compute thie commitment every time a proof (snark or stark) is generated.