Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: stable phase1/phase2 #84

Merged
merged 48 commits into from
Mar 27, 2025
Merged

Feat: stable phase1/phase2 #84

merged 48 commits into from
Mar 27, 2025

Conversation

lispc
Copy link
Contributor

@lispc lispc commented Mar 15, 2025 •
edited by roynalnaruto
Loading

Pending:

  • zkvm-prover/crates/verifier tests to PASS
  • zkvm-prover/crates/prover tests to PASS

@lispc lispc changed the title new phase1 release towards new phase1 release Mar 15, 2025
@github-actions github-actions bot added crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-prover Updates to the prover crate crate-verifier Updates to the verifier crate crate-circuits Any update made to the circuits, i.e. commitments reflect a change labels Mar 15, 2025
@github-actions github-actions bot added the crate-build-guest Updates to building of guest programs label Mar 17, 2025
@lispc lispc marked this pull request as ready for review March 17, 2025 02:12
@lispc
Copy link
Contributor Author

lispc commented Mar 18, 2025 •
edited
Loading

TODO for rc9:

  1. fix "msg_queue_hash" in pi hash even for phase1 issue https://scrollco.slack.com/archives/C06UP3R13MW/p1742308204662659?thread_ts=1742175361.690849&cid=C06UP3R13MW
  2. inside bundle guest program and metadata_with_prechecks, check the BundleInfo in BundleTask be consistent with bundle info from C::validate.https://scrollco.slack.com/archives/C06UP3R13MW/p1742307320799079?thread_ts=1742175361.690849&cid=C06UP3R13MW

@noel2004 noel2004 mentioned this pull request Mar 19, 2025
Merged
@noel2004
Copy link
Member

TODO for rc9:

  1. fix "msg_queue_hash" in pi hash even for phase1 issue https://scrollco.slack.com/archives/C06UP3R13MW/p1742308204662659?thread_ts=1742175361.690849&cid=C06UP3R13MW
  2. inside bundle guest program and metadata_with_prechecks, check the BundleInfo in BundleTask be consistent with bundle info from C::validate.https://scrollco.slack.com/archives/C06UP3R13MW/p1742307320799079?thread_ts=1742175361.690849&cid=C06UP3R13MW

#87

@noel2004
[Fix] for phase1 rc9 (#87)
e415b0b 
* fix pi hash in bundle

* add santiy check for bundle task

* fix typo and expression

* add local task test, output local task in e2e

* + add bundle local task sample, update batch local task sample
+ sanity check for final e2e bundle pi
@github-actions github-actions bot added the crate-integration Updates to the integration crate label Mar 19, 2025
@roynalnaruto
Phase-2 audit fixes (#98)
67bd009 
* fix(TOB-SCREUC2-3): use github output instead of github env

* fix(TOB-SCREUC2-4): pin 3rd party actions

* fix(TOB-SCREUC2-5): do not persist git credentials
@github-actions github-actions bot added the ci CI related updates label Mar 25, 2025
@lispc @noel2004
feat: runtime multi version (#81)
9d1ed70 
* circuit::types can support multi versions

* phase feature free for batch circuit

* fix issue after merging

* make chunk circuit feature free

* prune unnecessary commitment file, and revert verify_commitments update

* fix: soundnes in bundle circuit and typo

* bundle circuit feature free

* refactoring:
Rename codec_version => fork_name
unitfy the occurance of fork_name field among task and witness (not info)

* resume multiple version of bundle circuit

* update build-guest

* update make file

* fix build-guest

* update lock

* fix issue in build guest input

* enable co-exist of mutiple bundle app

* fix typo

* fix "most legacy" issue

* update release scripts

* [FEAT] better test structure (#82)

* better structure for testdata (WIP)

* fix chunk test and prune batch test (WIP)

* update make file and test samples

* test new batch test scheme

* add batch invariant test

* update makefile for required chunk proof

* prune unnecessary container cleanning

* fixings after rebase

* fix according to review: use more straight fashion for chunk task generations

* FIX: the correct order in batchheader enum

* better version setting for test task

* add readme files

* rename v3 to v6

* rename "legacy" to "euclidv1" according to review

* renaming in scripts

* task must use explicitily specified `fork_name`

* update the sanity check of bundle hash in e2e of phase v1 since the "version" field in batchheader changed (7->6)

---------

Co-authored-by: noelwei <fan@scroll.io>
Co-authored-by: Ho <noelwei@gmail.com>
@roynalnaruto roynalnaruto requested a review from lightsing as a code owner March 25, 2025 12:41
@github-actions github-actions bot added the crate-chunk-circuit Updates to the guest program chunk-circuit label Mar 25, 2025
@lispc lispc changed the title Feat: stable phase1 Feat: runtime multi version and other improvements Mar 26, 2025
@lispc lispc changed the title Feat: runtime multi version and other improvements Feat: stable phase1/phase2 Mar 26, 2025
lispc and others added 16 commits March 26, 2025 06:09
@lispc
fmt
29a0373
@noel2004
pruge unused bls12_381 openvm extension in bundle circuit
15a1dd9
@roynalnaruto
fix(TOB-SCREUC2-3) follow-up: extract variable and use
7b1f760
@lispc @noel2004
feat: rv32 chunk fallback (#100)
3f7a82c 
* feat: batch support rv32 chunk

* add ChunkRv32Prover and e2e tests, testing

* add commitment verify for rv32 fallback in verifier

* testing e2e

* add commitments

* toolchain & lint

* docker

* tag 0.2.0

* update commits

---------

Co-authored-by: noelwei <fan@scroll.io>
@lispc
clean
9cbe24a
@roynalnaruto
chore: cleanup
cf9842b
@lispc
chore: update commitments
bd39b91
@roynalnaruto
feat(build-guest): write digests
ccb5b00
@lispc
fix(build-guest): add digests
fc75d17
@roynalnaruto
fix: batch task v7 contains unpadded blob bytes, envelope v7 expects …
907f871 
…padded
@noel2004
[Feat] sanity check for pi while generating proof (#102)
96f1f05 
* sanity check for pi in proof gen

* update according to review

* fix another issue

* add missed assert

* resume the comment
@lispc
chore: update commitments
06362f4
@roynalnaruto
fix: update release script to push digests from correct source path
7c70db6
@roynalnaruto
fix(tests): prev msg queue hash population for euclidv1
a41bbec
@roynalnaruto
fix: sanity check on wrapped proof
1e17b93
@roynalnaruto
fix: tests
af368f3
roynalnaruto
roynalnaruto approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@roynalnaruto roynalnaruto merged commit 5854f81 into master Mar 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roynalnaruto roynalnaruto roynalnaruto approved these changes

@noel2004 noel2004 noel2004 approved these changes

@lightsing lightsing Awaiting requested review from lightsing lightsing is a code owner

Assignees
No one assigned
Labels
ci CI related updates crate-batch-circuit Updates to the guest program batch-circuit crate-build-guest Updates to building of guest programs crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-chunk-circuit Updates to the guest program chunk-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change crate-integration Updates to the integration crate crate-prover Updates to the prover crate crate-verifier Updates to the verifier crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lispc @noel2004 @roynalnaruto @kunxian-xia