fix NULL pointer dereference, backport A-MSDU fixes for Raspberry Pi, RSSI, Frame Control, Phy Bits, etc #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mzakharo
changed the title
This was referenced Jun 19, 2020
This was referenced Oct 7, 2020
|
great work! why this PR don't get any attention ? |
|
Excellent work Mikhail. Your changes fixed my problems. Check #177. I vote for the authors of nexmon_csi to merge your pull request. |
Closed
Closed
|
Hi @mzakharo I am using your pull request to obtain the RSSI value using Raspberry pi, but I found some problem with my data, the CSI value of the subcarrier from 28 to 35 are constant. (The subcarrier index range from 0 to 63) |
I am assuming bandwidth of your capture is 20Mhz. For whatever reason, on 20MHz bandwidth, carriers 28-35 have no valid data, this behaviour has nothing to do with this patch, and occurs on master branch. if you inspect data more closely, you still get the expected valid 52 complex values from other points in the CSI vector. |
Thanks for replying, I have checked the data from the master branch, indeed, the carriers 28-35 have no valid data. I just realised that they are corresponding to the null subcarrier in OFDM. |
|
Hi @mzakharo The frame control information from my side does not look good. It changes a lot. Also I was expecting frame control from different cores should be same, but actually they are not. Could you have a look? |
|
Frame control is added only for raspberry pi. You need the equivalent
assembly for your platform
…On Sat., Jul. 10, 2021, 15:11 haochenku, ***@***.***> wrote:
Hi @mzakharo <https://github.com/mzakharo> The frame control information
from my side does not look good. It changes a lot. Also I was expecting
frame control from different cores should be same, but actually they are
not. Could you have a look?
[image: image]
<https://user-images.githubusercontent.com/6502398/125174118-a8e03580-e188-11eb-8e60-dbcc77f59311.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKUO7ZYIK5OPLFK53UFTTTXCLNLANCNFSM4KZCUJEA>
.
|
|
thank you so much ! any guidance or reference on how to proceed ?
On Sat, Jul 10, 2021, 15:51 Mikhail Zakharov ***@***.***>
wrote:
… Frame control is added only for raspberry pi. You need the equivalent
assembly for your platform
On Sat., Jul. 10, 2021, 15:11 haochenku, ***@***.***> wrote:
> Hi @mzakharo <https://github.com/mzakharo> The frame control information
> from my side does not look good. It changes a lot. Also I was expecting
> frame control from different cores should be same, but actually they are
> not. Could you have a look?
> [image: image]
> <
https://user-images.githubusercontent.com/6502398/125174118-a8e03580-e188-11eb-8e60-dbcc77f59311.png
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#46 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAEKUO7ZYIK5OPLFK53UFTTTXCLNLANCNFSM4KZCUJEA
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRTP7QXBGFHFX56NN2N3KDTXCXGRANCNFSM4KZCUJEA>
.
|
|
Raspberry pi patch is your reference. Good luck
…On Sat., Jul. 10, 2021, 20:17 haochenku, ***@***.***> wrote:
thank you so much ! any guidance or reference on how to proceed ?
On Sat, Jul 10, 2021, 15:51 Mikhail Zakharov ***@***.***>
wrote:
> Frame control is added only for raspberry pi. You need the equivalent
> assembly for your platform
>
> On Sat., Jul. 10, 2021, 15:11 haochenku, ***@***.***> wrote:
>
> > Hi @mzakharo <https://github.com/mzakharo> The frame control
information
> > from my side does not look good. It changes a lot. Also I was expecting
> > frame control from different cores should be same, but actually they
are
> > not. Could you have a look?
> > [image: image]
> > <
>
https://user-images.githubusercontent.com/6502398/125174118-a8e03580-e188-11eb-8e60-dbcc77f59311.png
> >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
#46 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AAEKUO7ZYIK5OPLFK53UFTTTXCLNLANCNFSM4KZCUJEA
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#46 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABRTP7QXBGFHFX56NN2N3KDTXCXGRANCNFSM4KZCUJEA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKUO5X4ZTMNX5IPLJUXXDTXDPLBANCNFSM4KZCUJEA>
.
|
|
THank you. BTW, in the multiple core and stream case, could we assume that
the csi from core 0 always comes before csi from core 1?
On Sun, Jul 11, 2021 at 6:15 AM Mikhail Zakharov ***@***.***>
wrote:
… Raspberry pi patch is your reference. Good luck
On Sat., Jul. 10, 2021, 20:17 haochenku, ***@***.***> wrote:
> thank you so much ! any guidance or reference on how to proceed ?
>
> On Sat, Jul 10, 2021, 15:51 Mikhail Zakharov ***@***.***>
> wrote:
>
> > Frame control is added only for raspberry pi. You need the equivalent
> > assembly for your platform
> >
> > On Sat., Jul. 10, 2021, 15:11 haochenku, ***@***.***> wrote:
> >
> > > Hi @mzakharo <https://github.com/mzakharo> The frame control
> information
> > > from my side does not look good. It changes a lot. Also I was
expecting
> > > frame control from different cores should be same, but actually they
> are
> > > not. Could you have a look?
> > > [image: image]
> > > <
> >
>
https://user-images.githubusercontent.com/6502398/125174118-a8e03580-e188-11eb-8e60-dbcc77f59311.png
> > >
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub
> > > <
> #46 (comment)
> > >,
> > > or unsubscribe
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/AAEKUO7ZYIK5OPLFK53UFTTTXCLNLANCNFSM4KZCUJEA
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <
#46 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ABRTP7QXBGFHFX56NN2N3KDTXCXGRANCNFSM4KZCUJEA
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#46 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAEKUO5X4ZTMNX5IPLJUXXDTXDPLBANCNFSM4KZCUJEA
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRTP7T724NWJKVEF364ZHLTXGKNPANCNFSM4KZCUJEA>
.
|
|
For the most part yes. But i would not count on it. Werid things happen
from time to time.
…On Sun., Jul. 11, 2021, 14:59 haochenku, ***@***.***> wrote:
THank you. BTW, in the multiple core and stream case, could we assume that
the csi from core 0 always comes before csi from core 1?
On Sun, Jul 11, 2021 at 6:15 AM Mikhail Zakharov ***@***.***>
wrote:
> Raspberry pi patch is your reference. Good luck
>
> On Sat., Jul. 10, 2021, 20:17 haochenku, ***@***.***> wrote:
>
> > thank you so much ! any guidance or reference on how to proceed ?
> >
> > On Sat, Jul 10, 2021, 15:51 Mikhail Zakharov ***@***.***>
> > wrote:
> >
> > > Frame control is added only for raspberry pi. You need the equivalent
> > > assembly for your platform
> > >
> > > On Sat., Jul. 10, 2021, 15:11 haochenku, ***@***.***> wrote:
> > >
> > > > Hi @mzakharo <https://github.com/mzakharo> The frame control
> > information
> > > > from my side does not look good. It changes a lot. Also I was
> expecting
> > > > frame control from different cores should be same, but actually
they
> > are
> > > > not. Could you have a look?
> > > > [image: image]
> > > > <
> > >
> >
>
https://user-images.githubusercontent.com/6502398/125174118-a8e03580-e188-11eb-8e60-dbcc77f59311.png
> > > >
> > > >
> > > > —
> > > > You are receiving this because you were mentioned.
> > > > Reply to this email directly, view it on GitHub
> > > > <
> >
#46 (comment)
> > > >,
> > > > or unsubscribe
> > > > <
> > >
> >
>
https://github.com/notifications/unsubscribe-auth/AAEKUO7ZYIK5OPLFK53UFTTTXCLNLANCNFSM4KZCUJEA
> > > >
> > > > .
> > > >
> > >
> > > —
> > > You are receiving this because you commented.
> > > Reply to this email directly, view it on GitHub
> > > <
> #46 (comment)
> > >,
> > > or unsubscribe
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/ABRTP7QXBGFHFX56NN2N3KDTXCXGRANCNFSM4KZCUJEA
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
#46 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AAEKUO5X4ZTMNX5IPLJUXXDTXDPLBANCNFSM4KZCUJEA
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#46 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABRTP7T724NWJKVEF364ZHLTXGKNPANCNFSM4KZCUJEA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKUOYXOYTAY3BNWKUT3XLTXHSZXANCNFSM4KZCUJEA>
.
|
|
I see. Thank you. Is there any reliable way to distinguish the core 0 and
core 1 on from the same frame? Will time difference be good?
On Sun, Jul 11, 2021 at 3:46 PM Mikhail Zakharov ***@***.***>
wrote:
… For the most part yes. But i would not count on it. Werid things happen
from time to time.
On Sun., Jul. 11, 2021, 14:59 haochenku, ***@***.***> wrote:
> THank you. BTW, in the multiple core and stream case, could we assume
that
> the csi from core 0 always comes before csi from core 1?
>
> On Sun, Jul 11, 2021 at 6:15 AM Mikhail Zakharov ***@***.***>
> wrote:
>
> > Raspberry pi patch is your reference. Good luck
> >
> > On Sat., Jul. 10, 2021, 20:17 haochenku, ***@***.***> wrote:
> >
> > > thank you so much ! any guidance or reference on how to proceed ?
> > >
> > > On Sat, Jul 10, 2021, 15:51 Mikhail Zakharov ***@***.***>
> > > wrote:
> > >
> > > > Frame control is added only for raspberry pi. You need the
equivalent
> > > > assembly for your platform
> > > >
> > > > On Sat., Jul. 10, 2021, 15:11 haochenku, ***@***.***> wrote:
> > > >
> > > > > Hi @mzakharo <https://github.com/mzakharo> The frame control
> > > information
> > > > > from my side does not look good. It changes a lot. Also I was
> > expecting
> > > > > frame control from different cores should be same, but actually
> they
> > > are
> > > > > not. Could you have a look?
> > > > > [image: image]
> > > > > <
> > > >
> > >
> >
>
https://user-images.githubusercontent.com/6502398/125174118-a8e03580-e188-11eb-8e60-dbcc77f59311.png
> > > > >
> > > > >
> > > > > —
> > > > > You are receiving this because you were mentioned.
> > > > > Reply to this email directly, view it on GitHub
> > > > > <
> > >
> #46 (comment)
> > > > >,
> > > > > or unsubscribe
> > > > > <
> > > >
> > >
> >
>
https://github.com/notifications/unsubscribe-auth/AAEKUO7ZYIK5OPLFK53UFTTTXCLNLANCNFSM4KZCUJEA
> > > > >
> > > > > .
> > > > >
> > > >
> > > > —
> > > > You are receiving this because you commented.
> > > > Reply to this email directly, view it on GitHub
> > > > <
> >
#46 (comment)
> > > >,
> > > > or unsubscribe
> > > > <
> > >
> >
>
https://github.com/notifications/unsubscribe-auth/ABRTP7QXBGFHFX56NN2N3KDTXCXGRANCNFSM4KZCUJEA
> > > >
> > > > .
> > > >
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub
> > > <
> #46 (comment)
> > >,
> > > or unsubscribe
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/AAEKUO5X4ZTMNX5IPLJUXXDTXDPLBANCNFSM4KZCUJEA
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <
#46 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ABRTP7T724NWJKVEF364ZHLTXGKNPANCNFSM4KZCUJEA
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#46 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAEKUOYXOYTAY3BNWKUT3XLTXHSZXANCNFSM4KZCUJEA
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRTP7XWYPGDXL5AALSNDEDTXINL5ANCNFSM4KZCUJEA>
.
|
|
I don't know of any. My strategy has been to drop frames that are out of
order
…On Sun., Jul. 11, 2021, 20:33 haochenku, ***@***.***> wrote:
I see. Thank you. Is there any reliable way to distinguish the core 0 and
core 1 on from the same frame? Will time difference be good?
On Sun, Jul 11, 2021 at 3:46 PM Mikhail Zakharov ***@***.***>
wrote:
> For the most part yes. But i would not count on it. Werid things happen
> from time to time.
>
> On Sun., Jul. 11, 2021, 14:59 haochenku, ***@***.***> wrote:
>
> > THank you. BTW, in the multiple core and stream case, could we assume
> that
> > the csi from core 0 always comes before csi from core 1?
> >
> > On Sun, Jul 11, 2021 at 6:15 AM Mikhail Zakharov ***@***.***>
> > wrote:
> >
> > > Raspberry pi patch is your reference. Good luck
> > >
> > > On Sat., Jul. 10, 2021, 20:17 haochenku, ***@***.***> wrote:
> > >
> > > > thank you so much ! any guidance or reference on how to proceed ?
> > > >
> > > > On Sat, Jul 10, 2021, 15:51 Mikhail Zakharov ***@***.***>
> > > > wrote:
> > > >
> > > > > Frame control is added only for raspberry pi. You need the
> equivalent
> > > > > assembly for your platform
> > > > >
> > > > > On Sat., Jul. 10, 2021, 15:11 haochenku, ***@***.***> wrote:
> > > > >
> > > > > > Hi @mzakharo <https://github.com/mzakharo> The frame control
> > > > information
> > > > > > from my side does not look good. It changes a lot. Also I was
> > > expecting
> > > > > > frame control from different cores should be same, but actually
> > they
> > > > are
> > > > > > not. Could you have a look?
> > > > > > [image: image]
> > > > > > <
> > > > >
> > > >
> > >
> >
>
https://user-images.githubusercontent.com/6502398/125174118-a8e03580-e188-11eb-8e60-dbcc77f59311.png
> > > > > >
> > > > > >
> > > > > > —
> > > > > > You are receiving this because you were mentioned.
> > > > > > Reply to this email directly, view it on GitHub
> > > > > > <
> > > >
> >
#46 (comment)
> > > > > >,
> > > > > > or unsubscribe
> > > > > > <
> > > > >
> > > >
> > >
> >
>
https://github.com/notifications/unsubscribe-auth/AAEKUO7ZYIK5OPLFK53UFTTTXCLNLANCNFSM4KZCUJEA
> > > > > >
> > > > > > .
> > > > > >
> > > > >
> > > > > —
> > > > > You are receiving this because you commented.
> > > > > Reply to this email directly, view it on GitHub
> > > > > <
> > >
> #46 (comment)
> > > > >,
> > > > > or unsubscribe
> > > > > <
> > > >
> > >
> >
>
https://github.com/notifications/unsubscribe-auth/ABRTP7QXBGFHFX56NN2N3KDTXCXGRANCNFSM4KZCUJEA
> > > > >
> > > > > .
> > > > >
> > > >
> > > > —
> > > > You are receiving this because you were mentioned.
> > > > Reply to this email directly, view it on GitHub
> > > > <
> >
#46 (comment)
> > > >,
> > > > or unsubscribe
> > > > <
> > >
> >
>
https://github.com/notifications/unsubscribe-auth/AAEKUO5X4ZTMNX5IPLJUXXDTXDPLBANCNFSM4KZCUJEA
> > > >
> > > > .
> > > >
> > >
> > > —
> > > You are receiving this because you commented.
> > > Reply to this email directly, view it on GitHub
> > > <
> #46 (comment)
> > >,
> > > or unsubscribe
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/ABRTP7T724NWJKVEF364ZHLTXGKNPANCNFSM4KZCUJEA
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
#46 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AAEKUOYXOYTAY3BNWKUT3XLTXHSZXANCNFSM4KZCUJEA
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#46 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABRTP7XWYPGDXL5AALSNDEDTXINL5ANCNFSM4KZCUJEA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKUO2QMSDYEMUMBTICBJTTXIZ4VANCNFSM4KZCUJEA>
.
|
|
The reference file mentioned for decoding the phybits has been removed Is there any other source that has this information? |
https://github.com/RMerl/asuswrt-merlin.ng/blob/6b60627c8c9c5c0271e956c914afb5277f81f9c4/release/src-rt-6.x.4708/include/d11.h#L2517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I added the NULL pointer check, I monitored the log, and indeed, this check is happening sometimes. Also, A-MSDU skip helps Raspberry pi stay up without trapping.