fix the case of per-function custom Role #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress on this PR? I seem to be having the same issue that this PR is supposed to fix (custom roles, same stack, for each lambda function) |
|
could u add support for serverless-iam-roles-per-function? |
|
Sorry, it works perfect with serverless-iam-roles-per-function. Why it's not merged yet? |
|
tests added here #157 |
|
Any update on this? Did the merge fail just because the code coverage percentage was slightly decreased? |
|
@dwkerwin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a trouble with per-function custom Role, and needed to fix it.
I llooked around issues and pull requests, and found #87 and #88.
My custom role is in the same stack, so @bencodner 's solution does not apply.
So, I wrote another patch. It will cover cross-stack cases.