ARCH-6354: Optimize Get/SetFieldValue() to use integer indexes instead of search in Dictionary by string field name

[SergeiPavlov]

The [Field] properties inside class are sorted in order of MetadataToken value.

Properties, inherited from base class are first.

[botinko]

@SergeiPavlov check failed tests, I saw Index was outside the bounds of the array.

[botinko]

Looks very complex as it requires a lot of immersion in the code to understand the complexity of the algorithm. There is a serious lack of a test that would handle significant cases in BuildPersistentFields and GetBaseFields.

[SergeiPavlov]

There is a serious lack of a test that would handle significant cases in BuildPersistentFields and GetBaseFields.

I'm relying on existing tests. Looks like they cover all non-trivial cases (virtual Fields, fields from interfaces, new fields, recycled fields). During developement of this implementation I investigated many failed tests and improvend the implementation to satisfy them.

Anyway I have not merged it into master-servicetitan, lets test it for a while on ST app.

[botinko]

@SergeiPavlov
I see, that existent tests covers many cases.
I suspect that in the long run the lack of dedicated tests for this feature will make maintaining and developing this code problematic. The code is forgotten very quickly and after a couple of months it will no longer be possible to figure it out.
Tests give at least some chance to understand the logic and important features of the code.

I would just collect all non-trivial cases (virtual Fields, fields from interfaces, new fields, recycled fields, structs) in some test fixture.

[SergeiPavlov]

I would just collect all non-trivial cases (virtual Fields, fields from interfaces, new fields, recycled fields, structs) in some test fixture.

This would be copy/pasting existing tests