Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sssd_flush_cache() errors ignored #1221

Open
alejandro-colomar opened this issue Feb 21, 2025 · 0 comments
Open

sssd_flush_cache() errors ignored #1221

alejandro-colomar opened this issue Feb 21, 2025 · 0 comments

Comments

@alejandro-colomar
Copy link
Collaborator

alejandro-colomar commented Feb 21, 2025 •
edited
Loading

shadow/lib/sssd.c

Line 41 in 40bb89b

return -1;

shadow/lib/sssd.h

Line 13 in 40bb89b

#define sssd_flush_cache(service) (0)

This function (actually the macro when it's not being compiled) triggered an error while enabling -Werror=all, due to (all) callers ignoring the return value. Do we need to care about that return value when this function fails?

Cc: @jhrozek
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 21, 2025
@alejandro-colomar
lib/sssd.h: Add [[gnu::unused]] to function-like macro return value
4a06a62 
All callers ignore it.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 21, 2025
@alejandro-colomar
lib/sssd.h: Add [[gnu::unused]] to function-like macro return value
092f4c2 
All callers ignore it.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 21, 2025
@alejandro-colomar
lib/sssd.h: Add [[gnu::unused]] to function-like macro return value
583d31e 
All callers ignore it.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 21, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
9d0c609 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 21, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
d6b6c57 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 21, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
9c6e635 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 21, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
ad0452b 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 22, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
197febe 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 22, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
c5cf867 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 22, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
5248c86 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 23, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
0425ca7 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 23, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
53dec52 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 23, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
8628db6 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 23, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
6497817 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 23, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
7677b3c 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Feb 23, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
ed76909 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Mar 3, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
d096bc2 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Mar 4, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
03e902f 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this issue Mar 4, 2025
@alejandro-colomar
lib/sssd.h: sssd_flush_cache(): Define as static inline function
cb14be3 
Being a macro, the unused return value triggers a diagnostic.
This probably needs further investigation, but we have the issue linked
below for that.

Link: <shadow-maint#1221>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alejandro-colomar