Pulling from Joel's dbatools again #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use short inherited type name This fixes the issue where the type was not loading correctly I don't quite understand how, but it works! * Use runspaces for Invoke-Koan This allow us to apply "using module" properly for the koan files * Shorten type names for clarity * Modify koan file finding to be a little more reliable
* Reorganise all test scripts * Modify Psake script to adjust PSModulePath instead of copying files * Add Invoke-Koan.Tests * Rework location root behaviour for tests to be more robust * Use xplat-compatible path separators * Properly modify PSModulePath to pick up module to be imported.
* Permit Specifying and Listing Topics for Measure-Karma (#101) * Update Measure-Karma to support listing topics - Update Measure-Karma to support specifying topics to check * Update meditation prompts to support specified topics * Rename validator class for clarity * Rename list switch for consistency * Replace reference to old function name in Measure-Karma CBH * MODULE: Rename Write-MeditationPrompt to Show-MeditationPrompt Retain old name as alias * MODULE: Add Get/Set-PSKoanLocation cmdlets - Use module-scoped variable instead of environment variable - Add comment help to PSKoanLocation functions - Replace references to module variable with get/set function - Permit nonexistent paths for Set-PSKoanLocation - Add KoanLocation functions to PSD1 exports * MODULE: Add New-PSKoanErrorRecord & Improve topic searching - Supports regex patterns - Add New-PSKoanErrorRecord function for easy error record creation - Other small changes * MODULE: Rename module variables for clarity * TEST: Remove unneeded test headers - Invoke-Koan.Control_Tests - Get-Blank.Tests * MODULE/TEST: Refactor PSKoanLocation functions & add tests TEST: Resolve remaining tests issues TEST: Resolve outstanding issues with Measure-Karma tests - Add tests for behaviour when koan library is empty/missing MODULE: Ensure correct checking of total koans count TEST: Use #Requires -Module for tests - using module is not needed for module tests * MODULE: Fix broken Get-Koan behaviour when using -Topic * TEST: Finish adding Get-Koan Tests & fix #Requires declarations * MODULE: Add [OutputType()] to module functions * TEST: Preliminary tests for New-PSKoanErrorRecord * STYLE: Add spacing between header and function declaration * TEST: Complete New-PSKoanErrorRecord tests - Fix issue with type check * MODULE: Fix type name checking logic in New-PSKoanErrorRecord - Use more robust test method for exception type * TEST: Add test for Measure-Koan behaviour with -Topic param * STYLE: Add final line terminator to script files * BUILD: Restore working version of Publish.ps1 * STYLE: Consolidate style of comment-based help in module functions * MODULE: Improve Advice frameworks - Rename: Get-Advice -> Show-Advice - Reformat advice data files into json with Title and Content - Update Show-Advice and Write-ConsoleLine to handle title and contents. * MODULE: Make topic parameters behave more consistently * MODULE: Refactor Show-MeditationPrompt slightly * MODULE: Update KoanAttribute to support module name * MODULE: Update Register-Advice to use new cmdlet name in profile editing.
* MODULE: Remove Start-Sleep from meditation prompts * MODULE: Remove waiting periods from Invoke-Koan - Now should return pretty much as soon as the threaded task is completed - Remove reference to runspacePool that isn't being used here. * TEST: Remove test expectation for Start-Sleep
- Should error messages list expected values in a more sensible fashion
* MODULE: Display additional progress bar for farthest topic reached * TEST: Update Show-MeditationPrompt parameters in test run * MODULE: Restyle progress bars * MODULE: Add fallbacks for determining console width for progress bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping it up-to-date.