Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARD-2019 - Prettier lib-crypto-utils #13

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Conversation

mhanson-github
Copy link

@mhanson-github mhanson-github commented Mar 18, 2025

PR Type

enhancement, formatting


Description

  • Remove semicolons and enforce consistent formatting

  • Update Prettier configuration for wider print width

  • Adjust ESLint and TSLint configurations for consistency

  • Refactor test files to match new code style


Changes walkthrough 📝

Relevant files
Formatting
7 files
index.ts
Remove semicolons and enforce consistent formatting           
+165/-202
index.d.ts
Remove semicolons in TypeScript definitions                           
+160/-336
randomBytes.test.ts
Refactor test file to match new code style                             
+17/-17 
setup.ts
Remove semicolon in setup file                                                     
+2/-2     
jest.config.js
Remove semicolon in Jest configuration                                     
+11/-11 
test-sign-obj.js
Adjust spacing in test file                                                           
+1/-1     
test-tag-obj.js
Adjust spacing in test file                                                           
+1/-1     
Configuration changes
3 files
prettier.config.js
Update Prettier configuration for wider print width           
+2/-2     
.eslintrc.json
Adjust ESLint configuration for consistency                           
+1/-4     
tslint.json
Adjust TSLint configuration for consistency                           
+1/-3     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🏅 Score: 95
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Error Handling

    Ensure that all error messages are clear and provide enough context for debugging. Consider adding more specific error messages where applicable.

      throw new TypeError('Bytes must be given as integer greater than zero.')
    }
    const buf: Buffer = Buffer.allocUnsafe(bytes)
    sodium.randombytes_buf(buf)
    return buf.toString('hex')

    preset: 'ts-jest',
    testEnvironment: 'node',
    testTimeout: 5000000, // the more node involve in testing, the higher the timeout requires

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    testTimeout: 5000000, // the more node involve in testing, the higher the timeout requires

    BelfordZ
    BelfordZ previously approved these changes Mar 18, 2025
    @BelfordZ BelfordZ merged commit 9e50783 into mainnet-launch Mar 18, 2025
    5 checks passed
    @BelfordZ BelfordZ deleted the SHARD-2019-prettier branch March 18, 2025 19:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants